Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u-boot: 2017.11 -> v2018.03-rc3 #36340

Closed
wants to merge 1 commit into from
Closed

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Mar 5, 2018

this includes qemu-aarch64 support

Motivation for this change

I needed an updated u-boot for running my rpi3 sdcard with qemu. I figured I'd push it upstream right away.

Whether we can merge this as an -rc or not, I also wanted to document the patch I updated: It's based on dezgeg/u-boot@pythonpath-2018-03, but also accounts for u-boot/u-boot@15b97f5#diff-44b7a4b99d947fe1c4a313c4d890d8b6R384

cc @dezgeg does this look right to you?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

this includes qemu-aarch64 support
@Mic92
Copy link
Member

Mic92 commented Mar 5, 2018

see also #36232

defconfig = "qemu_arm_defconfig";
targetPlatforms = ["armv7l-linux"];
filesToInstall = ["u-boot.bin"];
};

ubootQemuArm_64bit = buildUBoot rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be ubootQemuAarch64, in Nixpkgs naming 'Arm' always stands for the 32-bit one.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 5, 2018

I also wanted to document the patch I updated: It's based on dezgeg/u-boot@pythonp, but also accounts for u-boot/u-boot@15b97f5#diff-44b7a4b99d947fe1c4a313c4d890d8b6R384

Thanks for the fix, I will squash that in my U-Boot patch branch for 2018.03.

As the 2018.03 upstream release is only a week away, let's wait for that, then have #36232 adjusted for 2018.03, then finally the ubootQemuAarch64 change.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 18, 2018

U-Boot 2018.03 and ubootQemuAarch64are now in master.

@dezgeg dezgeg closed this Mar 18, 2018
@bendlas bendlas deleted the update-u-boot branch October 22, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants