Use preinit_array to set argc/argv in init_globally example #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3208.
Proposed Changes
.preinit_arraysection instead of.init_arrayto getargcandargvin theinit_globallyexample.Any background context you want to provide?
The problem in #3204 was that
argcandargvwere not initialized before the globalmanage_global_runtimeobject was constructed, leadinghpx::startto fail (assumes thatargc >= 1).From my brief googling it seems that functions in
.preinit_arrayare supposed to run before constructors of global objects, but I could not find a definitive source (this was the best I could find), and it's not clear to me why release and debug behave differently. This should, however, not be worse than using.init_array.@NK-Nikunj Could you try this out to see that this doesn't just work on my system?