Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/options: teach showOptions about funny option names #36344

Merged
merged 1 commit into from May 26, 2018

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Mar 5, 2018

Handle the case where options have funny symbols inside of them.

Example:

If I reference the following attribute without it being defined:

security.acme.certs."example.com".webroot

I now get the error:

The option `security.acme.certs."example.com".webroot' is used but
not defined.

where before I got:

The option `security.acme.certs.example.com.webroot' is used but
not defined.

which is not true.

Handle the case where options have funny symbols inside of them.

Example:

If I reference the following attribute without it being defined:

  security.acme.certs."example.com".webroot

I now get the error:

    The option `security.acme.certs."example.com".webroot' is used but
    not defined.

where before I got:

    The option `security.acme.certs.example.com.webroot' is used but
    not defined.

which is not true.
@grahamc
Copy link
Member Author

grahamc commented Mar 5, 2018

@GrahamcOfBorg eval

1 similar comment
@grahamc
Copy link
Member Author

grahamc commented May 26, 2018

@GrahamcOfBorg eval

@grahamc grahamc merged commit 951e909 into NixOS:master May 26, 2018
@grahamc grahamc deleted the fancy-option-names branch May 26, 2018 00:55
@danbst
Copy link
Contributor

danbst commented Jun 24, 2018

oh. we've duplicated work
#20839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants