Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dd-agent: Excluding tracefs from disk checks #36335

Closed
wants to merge 1 commit into from
Closed

dd-agent: Excluding tracefs from disk checks #36335

wants to merge 1 commit into from

Conversation

fboussarsar
Copy link

@fboussarsar fboussarsar commented Mar 5, 2018 •
edited

The agent generates a lot of warning logs due to permission issues on tracefs

Motivation for this change

Datadog complains about permissions to access tracefs every run:

dd-agent:2018-02-14 11:00:40,697 | WARNING | dd.collector | checks.disk(disk.py:106) | Unable to get disk metrics for /sys/kernel/debug/tracing: [Errno 13] Permission denied: '/sys/kernel/debug/tracing'
Being unable to imagine a scenario where this FS needs monitoring, I assume it's wise to exclude it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fboussarsar
dd-agent: Excluding tracefs from disk checks
5e4909b 
The agent generates a lot of warning logs due to permission issues on tracefs
@etu
Copy link
Contributor

etu commented Mar 12, 2018

I guess this could be done:
cc @thoughtpolice @domenkozar

@cleverca22
Copy link
Contributor

i think the excluded_filesystems should be a config option, i'm getting similar errors for an FS i mounted under my $HOME, which isnt readable by datadog

@mmahut
Copy link
Member

mmahut commented Aug 3, 2019

What is the status of this pull request?

@mmahut
Copy link
Member

mmahut commented Oct 5, 2019

Closing due to lack of activity, feel free to re-open this if needed.

@mmahut mmahut closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fboussarsar @etu @cleverca22 @mmahut @GrahamcOfBorg