Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv3: Fix pkg-config lib path #35909

Closed
wants to merge 1 commit into from
Closed

opencv3: Fix pkg-config lib path #35909

wants to merge 1 commit into from

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Feb 28, 2018 •
edited

Fixes #35886

Motivation for this change

The library path pkg-config supplies for an OpenCV built from the opencv3 definition in nixpkgs is wrong: it appends the absolute path of the lib directory to the $out directory.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Thanks! If possible look into upstreaming (if that makes sense).

@matthewbauer
Copy link
Member

Also has merge conflicts currently

@acowley
Copy link
Contributor Author

acowley commented Apr 23, 2018

This patch applied to OpenCV 3.3 when that was in nixpkgs, but is no longer needed in 3.4.

@acowley acowley closed this Apr 23, 2018
@matthewbauer
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acowley @matthewbauer @GrahamcOfBorg