Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libgee_0_{6,8}: get rid of legacy libgee #35910

Merged
merged 1 commit into from Feb 28, 2018
Merged

libgee_0_{6,8}: get rid of legacy libgee #35910

merged 1 commit into from Feb 28, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 28, 2018 •
edited

Motivation for this change

It was never needed anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
libgee_0_{6,8}: get rid of legacy libgee
150ead9 
It was never needed anyway. [1]

[1]: NixOS#19421
@jtojnar jtojnar merged commit 150ead9 into NixOS:master Feb 28, 2018
@jtojnar jtojnar deleted the prune-libgee branch February 28, 2018 15:19
@pSub
Copy link
Member

pSub commented Jul 19, 2018

This broke gnome-encfs-manager:

error: Package `gee-0.8' not found in specified Vala API directories or GObject-Introspection GIR directories

@jtojnar
Copy link
Contributor Author

jtojnar commented Jul 19, 2018

Most likely it is just a missing gobjectIntrospection setup hook. gee-0.8 is the current version of libgee provided by gnome3.libgee.

@pSub
Copy link
Member

pSub commented Jul 20, 2018

Ok. I'll try this. Thanks.

@pSub
Copy link
Member

pSub commented Jul 20, 2018

That worked. Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @pSub @GrahamcOfBorg