ccache: 3.3.5 -> 3.4.1 #36110
Merged
ccache: 3.3.5 -> 3.4.1 #36110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuskowa
reviewed
Feb 28, 2018
| @@ -1,18 +1,23 @@ | |||
| { stdenv, fetchurl, fetchpatch, runCommand, zlib, makeWrapper }: | |||
| { stdenv, fetchurl, fetchpatch, runCommand, perl, gcc, zlib, makeWrapper }: | |||
There was a problem hiding this comment.
Is there a particular reason why gcc is a native build input? gcc should be part of stdenv.
There was a problem hiding this comment.
Without perl tests will fail with this error:
PASSED: 483 assertions, 96 tests, 10 suites
CC='gcc' /nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash ./test/run
./test/run: line 51: perl: command not found
Compiler: gcc ()
Compiler version: gcc (GCC) 7.3.0
./test/run: line 51: perl: command not found
./test/run: line 51: perl: command not found
CUDA compiler: not available
Running test suite base../test/suites/base.bash: line 5: -c: command not found
FAILED
Test suite: base
Test case: Base case
Failure reason: Objects differ: reference_test1.o != test1.o
ccache -s:
cache directory /tmp/nix-build-ccache-3.4.1.drv-2/ccache-3.4.1/testdir.24043/.ccache
primary config /tmp/nix-build-ccache-3.4.1.drv-2/ccache-3.4.1/testdir.24043/ccache.conf
secondary config (readonly)
stats zero time Wed Feb 28 13:47:29 2018
cache hit (direct) 0
cache hit (preprocessed) 0
cache miss 1
cache hit rate 0.00 %
cleanups performed 0
files in cache 1
cache size 4.1 kB
max cache size 5.0 GB
Test data and log file have been left in testdir.24043
make: *** [Makefile:106: test] Error 1
There was a problem hiding this comment.
gcc was removed from nativeBuildInputs.
added 2 commits
February 28, 2018 16:55
- `gcc` was removed from `nativeBuildInputs` - ccache version updated to 3.4.1 - added `man` subpackage
ghost
changed the title
|
@GrahamcOfBorg build ccache |
|
Success on x86_64-darwin (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update ccache version and make it working with GCC 7.3.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)