Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permanent redirct issues detected by Repology #36107

Closed
wants to merge 4 commits into from
Closed

Fix permanent redirct issues detected by Repology #36107

wants to merge 4 commits into from

Conversation

mt-caret
Copy link
Contributor

Motivation for this change

Trivial search-and-replace for urls that have permanent redirects.
This partially addresses #30636.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mt-caret mt-caret changed the title Fix urls Fix permanent redirct issues detected by Repology Feb 28, 2018
peti
peti previously requested changes Feb 28, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read the very first line of pkgs/development/haskell-modules/hackage-packages.nix. That is a generated file and any changes you make there manually will be lost during the next update.

@mt-caret
Copy link
Contributor Author

mt-caret commented Mar 2, 2018

Fixed.

globin
globin requested changes Mar 2, 2018
View reviewed changes
pkgs/tools/backup/tarsnapper/remove-argparse.patch Outdated
@@ -1,7 +1,7 @@
--- tarsnapper-0.4-src.org/setup.py 1980-01-02 00:00:00.000000000 +0000
+++ tarsnapper-0.4-src/setup.py 2017-07-16 10:54:36.596499451 +0100
@@ -45,6 +45,6 @@
url='http://github.com/miracle2k/tarsnapper',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the patch

pkgs/tools/text/unoconv/unoconv-python3.patch Outdated
@@ -357,10 +357,10 @@ index 30e6706..f72cf08 100755
# debug_office()
- print >>sys.stderr, "unoconv: Cannot find a suitable office installation on your system."
- print >>sys.stderr, "ERROR: Please locate your office installation and send your feedback to:"
- print >>sys.stderr, " http://github.com/dagwieers/unoconv/issues"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the patch

@mt-caret
Copy link
Contributor Author

mt-caret commented Mar 3, 2018

Fixed

@mt-caret
Copy link
Contributor Author

ping @globin @FRidh ?

@FRidh
Copy link
Member

FRidh commented Mar 18, 2018

I think it is ok though I have not verified all changes.

@mt-caret
Copy link
Contributor Author

mt-caret commented Apr 3, 2018

ping @globin ?

@FRidh
Copy link
Member

FRidh commented Apr 3, 2018

@mt-caret if you rebase, squash the commits, and ping me, then I'll merge it.

@FRidh FRidh self-assigned this Apr 3, 2018
@mt-caret
Copy link
Contributor Author

I'm a bit busy right now and can't foresee when I'll be able to do this, so I'm closing this PR. I might try again sometime in the future, though.

@mt-caret mt-caret closed this Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin globin requested changes

@peti peti peti left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: haskell 6.topic: nixos 6.topic: python 6.topic: vim 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mt-caret @FRidh @peti @globin @GrahamcOfBorg