fix assert on self-referencing function ptr field #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The construct `struct S { f: fn(S) void }` is not legal because structs
are not copyable but it should not result in an ICE.
Fixes #795.
andrewrk
reviewed
Feb 28, 2018
| @@ -1670,6 +1670,9 @@ static void resolve_struct_type(CodeGen *g, TypeTableEntry *struct_type) { | |||
| if (struct_type->data.structure.is_invalid) | |||
| return; | |||
|
|
|||
| if (struct_type->data.structure.zero_bits_loop_flag) | |||
There was a problem hiding this comment.
hmm this doesn't seem right to me. if we return from resolve_struct_zero_bits then either zero_bits_loop_flag should be false or is_invalid should be true. Let me poke at it.
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The construct
struct S { f: fn(S) void }is not legal because structsare not copyable but it should not result in an ICE.
Fixes #795.
Best possible fix or not? There is existing logic for detecting self-recursive types but this isn't quite that. Suggestions welcome.