Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix QML designer in Qt Creator #34929

Closed
wants to merge 2 commits into from
Closed

Fix QML designer in Qt Creator #34929

wants to merge 2 commits into from

Conversation

abbradar
Copy link
Member

Motivation for this change

Ditto.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@abbradar
qtEnv: fix paths in qt.conf
8e1de2a 
The shell variables from setup hook are not visible here, so instead substitute
them from Nix side.
@abbradar
qtcreator: fix path to qtquickcontrols
8c5b244 
This enables build of QML designer plugin.
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘qtcreator-4.5.0’ in /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/development/qtcreator/default.nix:49 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

g++ -c -pipe -Wno-noexcept-type -O2 -std=gnu++1y -fvisibility=hidden -fvisibility-inlines-hidden -Wall -W -D_REENTRANT -fPIC -D'RELATIVE_PLUGIN_PATH="../lib/qtcreator/plugins"' -D'RELATIVE_LIBEXEC_PATH="../libexec/qtcreator"' -D'RELATIVE_DATA_PATH="../share/qtcreator"' -D'RELATIVE_DOC_PATH="../share/doc/qtcreator"' -DIDE_LIBRARY_BASENAME=\"lib\" -DQT_CREATOR -DQT_NO_CAST_TO_ASCII -DQT_RESTRICTED_CAST_FROM_ASCII -DQT_DISABLE_DEPRECATED_BEFORE=0x050600 -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_FAST_CONCATENATION -DQT_NO_DEBUG -DQT_PLUGIN -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_CONCURRENT_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I../../../src -I../../../src -I../../libs -I/tmp/nix-build-qtcreator-4.5.0.drv-0/qt-creator-opensource-src-4.5.0/tools -I../../plugins -I../../libs/3rdparty -I. -isystem /nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/include/QtWidgets -isystem /nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/include/QtGui -isystem /nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/include/QtConcurrent -isystem /nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/include/QtNetwork -isystem /nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/include/QtCore -I.moc/release-shared -isystem /nix/store/kq4wn73vwrrskvyxdkqik00f5g2fms11-mesa-noglu-17.3.3-dev/include -I.uic -I/nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/mkspecs/linux-g++ -o .obj/release-shared/moc_subversionsubmiteditor.o .moc/release-shared/moc_subversionsubmiteditor.cpp
rm -f libSubversion.so
g++ -Wl,-z,origin '-Wl,-rpath,$ORIGIN:$ORIGIN/..:$ORIGIN/../lib/qtcreator' -Wl,--no-undefined -Wl,-O1 -Wl,-rpath,/nix/store/lc14313s5cnzpmzwmfkd3is9xjqgfi4p-qtbase-5.10.0/lib -shared -Wl,-soname,libSubversion.so -o libSubversion.so .obj/release-shared/annotationhighlighter.o .obj/release-shared/subversionplugin.o .obj/release-shared/subversionclient.o .obj/release-shared/subversioncontrol.o .obj/release-shared/settingspage.o .obj/release-shared/subversioneditor.o .obj/release-shared/subversionsubmiteditor.o .obj/release-shared/subversionsettings.o .obj/release-shared/moc_annotationhighlighter.o .obj/release-shared/moc_subversionplugin.o .obj/release-shared/moc_subversionclient.o .obj/release-shared/moc_subversioncontrol.o .obj/release-shared/moc_settingspage.o .obj/release-shared/moc_subversioneditor.o .obj/release-shared/moc_subversionsubmiteditor.o  -L/nix/store/i7zgfnqikkn1xyq26amh21f20dikjhwc-mesa-noglu-17.3.3/lib -L/tmp/nix-build-qtcreator-4.5.0.drv-0/qt-creator-opensource-src-4.5.0/lib/qtcreator -L/tmp/nix-build-qtcreator-4.5.0.drv-0/qt-creator-opensource-src-4.5.0/lib/qtcreator/plugins -lTextEditor -lCore -lVcsBase -lDiffEditor -lProjectExplorer -lCppTools -lAggregation -lQtcSsh -lCPlusPlus -lExtensionSystem -lUtils -L/nix/store/lc14313s5cnzpmzwmfkd3is9xjqgfi4p-qtbase-5.10.0/lib -lQt5Widgets -L/lib -lQt5Gui -lQt5Concurrent -lQt5Network -lQt5Core -lGL -lpthread  
mv -f libSubversion.so ../../../lib/qtcreator/plugins/ 
make[3]: Leaving directory '/tmp/nix-build-qtcreator-4.5.0.drv-0/qt-creator-opensource-src-4.5.0/src/plugins/subversion'
cd git/ && ( test -e Makefile || /nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/bin/qmake -o Makefile /tmp/nix-build-qtcreator-4.5.0.drv-0/qt-creator-opensource-src-4.5.0/src/plugins/git/git.pro PREFIX=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0 NIX_OUTPUT_OUT=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0 NIX_OUTPUT_DEV=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0 NIX_OUTPUT_BIN=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0 NIX_OUTPUT_DOC=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0/share/doc/qt-5.10 NIX_OUTPUT_QML=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0/lib/qt-5.10/qml NIX_OUTPUT_PLUGIN=/nix/store/1xr9w9582704dp5hlsgcj19s4c8ks095-qtcreator-4.5.0/lib/qt-5.10/plugins QMAKE_LRELEASE=/nix/store/678yhn73c8455hc967w9g1qmjay59d3d-qttools-5.10.0-dev/bin/lrelease ) && make -f Makefile 
make[3]: Entering directory '/tmp/nix-build-qtcreator-4.5.0.drv-0/qt-creator-opensource-src-4.5.0/src/plugins/git'
/nix/store/nm28c518xfkgg778nzr1z3sgyy2v85pv-qtbase-5.10.0-dev/bin/uic -no-stringliteral changeselectiondialog.ui -o .uic/ui_changeselectiondialog.h
building of ‘/nix/store/1m616fd6khrsy554dl0yxadkwnp6rwdf-qtcreator-4.5.0.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/1m616fd6khrsy554dl0yxadkwnp6rwdf-qtcreator-4.5.0.drv’ failed

bjornfor
bjornfor approved these changes Feb 17, 2018
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with NIX_PATH=nixpkgs=$PWD nix-shell -p qt5Full -p qtcreator --run qtcreator.

@bjornfor
Copy link
Contributor

I can confirm that editing QML UI is broken in master and this PR fixes it (thanks!).

Applied to master (9c88273, 4490140).

@bjornfor bjornfor closed this Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
0.kind: bug 6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@abbradar @GrahamcOfBorg @bjornfor