Ocaml Janestreet Packages: fix installation path of stub dlls. #34931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please show an example of something that is broken, so as to better understand the issue you are addressing? |
|
core was not usable in utop, because it failed to load libstubbase.so (from base) and libstubexpect_collect.so (from expect_ppx) |
8 tasks
|
I’m not sure that the issue comes from where the libraries are installed. See #34981 for an other approach. |
|
Agreed, #34981 is probably better. lambdaterm and nocrypto move their stubslibs, I don't know if it's useful. |
|
Does this mean that this PR is obsolete? |
|
Closing because PR appears to be obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The install phase of Jane Street's ocaml packages puts any .so libs in site-lib/stublibs, while findlib (?) looks for them in site-lib/$name. This moves the .so where they should be.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)