Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autojump: install fish shell completions #34923

Merged
merged 1 commit into from Feb 17, 2018
Merged

autojump: install fish shell completions #34923

merged 1 commit into from Feb 17, 2018

Conversation

jlesquembre
Copy link
Member

Motivation for this change

fish shell completions should be at /share/fish/vendor_completions.d/:

nixpkgs/nixos/modules/programs/fish.nix

Lines 168 to 172 in 57707ea

# include programs that bring their own completions
environment.pathsToLink = []
++ optional cfg.vendor.config.enable "/share/fish/vendor_conf.d"
++ optional cfg.vendor.completions.enable "/share/fish/vendor_completions.d"
++ optional cfg.vendor.functions.enable "/share/fish/vendor_functions.d";

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jlesquembre
Copy link
Member Author

@GrahamcOfBorg build autojump

@joachifm joachifm merged commit 1c02b6e into NixOS:master Feb 17, 2018
@joachifm
Copy link
Contributor

Thank you

@jlesquembre jlesquembre deleted the autojump branch February 26, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @joachifm @GrahamcOfBorg