Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby: remove unsupported versions #34927

Merged
merged 1 commit into from Feb 14, 2018
Merged

ruby: remove unsupported versions #34927

merged 1 commit into from Feb 14, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Feb 13, 2018

Motivation for this change

Help with #22357 a bit.

Remove EOL ruby versions for security and maintenance reasons.

Only expose ruby_MAJOR_MINOR to the top-level. we don't provide
guarantees for the TINY version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Feb 13, 2018

Sounds good. I would also remove 2.2 before nixpkgs 18.03, as its maintenance is scheduled to end in March.

@vcunat vcunat mentioned this pull request Feb 13, 2018
Merged
@zimbatm
Copy link
Member Author

zimbatm commented Feb 13, 2018

There is still work needed on that PR. Make sure the evaluation works and all packages depending on older ruby versions are marked as broken.

One thing that might also be considered is to switch the default ruby version to 2.4 or 2.5. I'm expecting that this will bring a lot of regressions.

@vcunat
Copy link
Member

vcunat commented Feb 13, 2018

@globin switched the default to 2.4 in #22357.

@zimbatm zimbatm force-pushed the ruby-remove-old branch 4 times, most recently from 0f83fd7 to eeab6a1 Compare February 13, 2018 15:55
@zimbatm
ruby: remove unsupported versions
42646f6 
* remove EOL ruby versions for security and maintenance reasons.
* only expose ruby_MAJOR_MINOR to the top-level. we don't provide
guarantees for the TINY version.
* mark all related packages as broken
* switch the default ruby version from 2.3.x to 2.4.x
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

RubyGems installed the following executables:
	/nix/store/shymf7w0q5374zir1kzi1fynwai1yj66-ruby-2.4.3/bin/gem

/private/tmp/nix-build-ruby-2.4.3.drv-0/source
post-installation fixup
gzipping man pages under /nix/store/shymf7w0q5374zir1kzi1fynwai1yj66-ruby-2.4.3/share/man/
strip is /nix/store/5a88zk3jgimdmzg8rfhvm93kxib3njf9-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/shymf7w0q5374zir1kzi1fynwai1yj66-ruby-2.4.3/lib  /nix/store/shymf7w0q5374zir1kzi1fynwai1yj66-ruby-2.4.3/bin
patching script interpreter paths in /nix/store/shymf7w0q5374zir1kzi1fynwai1yj66-ruby-2.4.3
/nix/store/shymf7w0q5374zir1kzi1fynwai1yj66-ruby-2.4.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/lib/ruby/2.4.0/x86_64-linux/gdbm.so
shrinking /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/lib/ruby/2.4.0/x86_64-linux/digest.so
shrinking /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/lib/ruby/2.4.0/x86_64-linux/fcntl.so
shrinking /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/lib/libruby.so.2.4.3
gzipping man pages under /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/lib  /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3/bin 
patching script interpreter paths in /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3
checking for references to /tmp/nix-build-ruby-2.4.3.drv-0 in /nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3...
/nix/store/77cnwanxlf9jqzysm9kxmmjmbbqlvp1y-ruby-2.4.3

@zimbatm
Copy link
Member Author

zimbatm commented Feb 13, 2018

@globin ok I switched the default ruby as well. looks like it's ready!

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/lib/ruby/2.4.0/aarch64-linux/socket.so
shrinking /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/lib/libruby.so.2.4.3
shrinking /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/bin/ruby
gzipping man pages under /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/lib  /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3/bin
patching script interpreter paths in /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3
checking for references to /build in /nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3...
/nix/store/rq02m2wm0bzpaj92ign8qrsxgh520mzd-ruby-2.4.3

@zimbatm zimbatm merged commit e8194c2 into NixOS:master Feb 14, 2018
@zimbatm zimbatm deleted the ruby-remove-old branch February 14, 2018 09:53
alyssais added a commit to alyssais/nixpkgs that referenced this pull request Sep 19, 2018
@alyssais
Revert "ruby: remove unsupported versions (NixOS#34927)"
2c1e35a 
This reverts commit e8194c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ruby 6.topic: vim 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @vcunat @GrahamcOfBorg