Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smenu: 0.9.10 -> 0.9.11 #34920

Closed
wants to merge 1 commit into from
Closed

smenu: 0.9.10 -> 0.9.11 #34920

wants to merge 1 commit into from

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

joachifm
joachifm reviewed Feb 13, 2018
View reviewed changes
pkgs/tools/misc/smenu/default.nix
@@ -1,14 +1,14 @@
{ stdenv, fetchFromGitHub, ncurses }:

stdenv.mkDerivation rec {
version = "v0.9.10";
version = "v0.9.11";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider fixing the version string as well.

@joachifm
Copy link
Contributor

@GrahamcOfBorg build smenu

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘smenu-v0.9.11’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/misc/smenu/default.nix:18 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-smenu-v0.9.11.drv-0/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11
shrinking /nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11/bin/smenu
gzipping man pages under /nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11/bin 
patching script interpreter paths in /nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11
checking for references to /tmp/nix-build-smenu-v0.9.11.drv-0 in /nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11...
/nix/store/6naan7gg8xigkfqghhfi0ajbrydpzckq-smenu-v0.9.11

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/source'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11
shrinking /nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11/bin/smenu
gzipping man pages under /nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11/share/man/
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11/bin
patching script interpreter paths in /nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11
checking for references to /build in /nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11...
/nix/store/1q330i5wr2p2hdzv287ycrkbblrh1qbm-smenu-v0.9.11

@matthiasbeyer
Copy link
Contributor Author

@joachifm please merge or pick on master.

@joachifm
Copy link
Contributor

The version string is still malformed

@matthiasbeyer matthiasbeyer deleted the update-smenu branch March 11, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @joachifm @GrahamcOfBorg