Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lldb_4: fix w/gcc7 #36463

Merged
merged 1 commit into from Mar 8, 2018
Merged

lldb_4: fix w/gcc7 #36463

merged 1 commit into from Mar 8, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 7, 2018 •
edited

Same fix used in swift4, FWIW.

cc ZHF #36453

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
lldb_4: fix w/gcc7
535ba5f 
Same fix used in swift4, FWIW.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/bin/lldb-4.0.1
shrinking /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/bin/lldb-argdumper
shrinking /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/lib/liblldb.so.4.0.1
shrinking /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/lib/python2.7/site-packages/readline.so
gzipping man pages under /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/lib  /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1/bin
patching script interpreter paths in /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1
checking for references to /build in /nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1...
/nix/store/vfn629iq9h946lif592h7gq2h7j6a30v-lldb-4.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1/lib/liblldb.4.0.1.dylib: fixing dylib
/nix/store/55jsvflmy5mw7r503fhmrpiiqqn8fwfp-lldb-4.0.1

@dtzWill
Copy link
Member Author

dtzWill commented Mar 8, 2018

x86_64-linux looks good, you can see log here: https://logs.nix.ci/?attempt_id=9af7b85b-ea79-458d-ba9d-c855eea0fdc4&key=nixos%2Fnixpkgs.36463

@dtzWill dtzWill merged commit a9abec1 into NixOS:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg