Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libetpan: 1.6 -> 1.8 #36488

Merged
merged 2 commits into from Apr 9, 2018
Merged

libetpan: 1.6 -> 1.8 #36488

merged 2 commits into from Apr 9, 2018

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented Mar 8, 2018 •
edited

Motivation for this change

Version bump as package I'm building needs functions from the current version. and updated mailcore2 as it was needed to work with the more modern libetpan
libetpan: 1.6-> 1.8
mailcore2: 0.5.1 -> 0.6.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 8, 2018 •
edited

@GrahamcOfBorg build libetpan claws-mail mailcore2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘libetpan-1.8’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/libetpan/default.nix:19 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/c2pgns63qw5r9crvcmqqvxqkhwlwybi4-claws-mail-3.16.0/lib  /nix/store/c2pgns63qw5r9crvcmqqvxqkhwlwybi4-claws-mail-3.16.0/bin 
patching script interpreter paths in /nix/store/c2pgns63qw5r9crvcmqqvxqkhwlwybi4-claws-mail-3.16.0
checking for references to /tmp/nix-build-claws-mail-3.16.0.drv-0 in /nix/store/c2pgns63qw5r9crvcmqqvxqkhwlwybi4-claws-mail-3.16.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/g5m3m8jybfifyrnhvq634wm36r16c7zg-claws-mail-3.16.0-dev
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/g5m3m8jybfifyrnhvq634wm36r16c7zg-claws-mail-3.16.0-dev/lib 
patching script interpreter paths in /nix/store/g5m3m8jybfifyrnhvq634wm36r16c7zg-claws-mail-3.16.0-dev
checking for references to /tmp/nix-build-claws-mail-3.16.0.drv-0 in /nix/store/g5m3m8jybfifyrnhvq634wm36r16c7zg-claws-mail-3.16.0-dev...
error: build of ‘/nix/store/j6igd44y0qzdzxa7lgb8lgkq29cxxy5v-mailcore2-0.5.1.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gsyn12i99p3ayn7naj6ngx9mdgazwb95-claws-mail-3.16.0/lib  /nix/store/gsyn12i99p3ayn7naj6ngx9mdgazwb95-claws-mail-3.16.0/bin
patching script interpreter paths in /nix/store/gsyn12i99p3ayn7naj6ngx9mdgazwb95-claws-mail-3.16.0
checking for references to /build in /nix/store/gsyn12i99p3ayn7naj6ngx9mdgazwb95-claws-mail-3.16.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/q79n8di6615l9vpvwqfn5a1iw8wisa10-claws-mail-3.16.0-dev
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/q79n8di6615l9vpvwqfn5a1iw8wisa10-claws-mail-3.16.0-dev/lib
patching script interpreter paths in /nix/store/q79n8di6615l9vpvwqfn5a1iw8wisa10-claws-mail-3.16.0-dev
checking for references to /build in /nix/store/q79n8di6615l9vpvwqfn5a1iw8wisa10-claws-mail-3.16.0-dev...
�[31;1merror:�[0m build of '/nix/store/xyhr2rg1wj82b3c226mrwsr23303mav2-mailcore2-0.5.1.drv' failed

@mogorman
Copy link
Contributor Author

mogorman commented Mar 8, 2018 •
edited

claws-mail built on my machine as is.
mailcore2 had a broken unit test related to char encoding I believe.
i updated it to its current version and problem went away

@ryantm
Copy link
Member

ryantm commented Mar 8, 2018

@GrahamcOfBorg build mailcore2

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘libetpan-1.8’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/libraries/libetpan/default.nix:19 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/86yazdq1zjwlwr5vm935c2lb7r0rgfd5-mailcore2-0.6.2
shrinking /nix/store/86yazdq1zjwlwr5vm935c2lb7r0rgfd5-mailcore2-0.6.2/lib/libMailCore.so
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/86yazdq1zjwlwr5vm935c2lb7r0rgfd5-mailcore2-0.6.2/lib
patching script interpreter paths in /nix/store/86yazdq1zjwlwr5vm935c2lb7r0rgfd5-mailcore2-0.6.2
checking for references to /build in /nix/store/86yazdq1zjwlwr5vm935c2lb7r0rgfd5-mailcore2-0.6.2...
/nix/store/86yazdq1zjwlwr5vm935c2lb7r0rgfd5-mailcore2-0.6.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/xcxj96hmxqx8rb1ip7zj0gspm9w8i1l5-mailcore2-0.6.2
shrinking /nix/store/xcxj96hmxqx8rb1ip7zj0gspm9w8i1l5-mailcore2-0.6.2/lib/libMailCore.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/xcxj96hmxqx8rb1ip7zj0gspm9w8i1l5-mailcore2-0.6.2/lib 
patching script interpreter paths in /nix/store/xcxj96hmxqx8rb1ip7zj0gspm9w8i1l5-mailcore2-0.6.2
checking for references to /tmp/nix-build-mailcore2-0.6.2.drv-0 in /nix/store/xcxj96hmxqx8rb1ip7zj0gspm9w8i1l5-mailcore2-0.6.2...
/nix/store/xcxj96hmxqx8rb1ip7zj0gspm9w8i1l5-mailcore2-0.6.2

@ryantm
Copy link
Member

ryantm commented Mar 8, 2018 •
edited

@GrahamcOfBorg build libetpan

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘libetpan-1.8’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/libetpan/default.nix:19 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/hryv2h1w3zlsimr3qfb8bafqi5c6jl4m-libetpan-1.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-libetpan-1.8.drv-0/libetpan'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8
shrinking /nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8/lib/libetpan.so.20.1.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8/lib  /nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8/bin 
patching script interpreter paths in /nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8
/nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8/bin/libetpan-config: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-libetpan-1.8.drv-0 in /nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8...
/nix/store/ly0ibz6xhbwf0mqiph5q0g3cns13l30v-libetpan-1.8

@ryantm
Copy link
Member

ryantm commented Mar 8, 2018

looks good to me

@ryantm
Copy link
Member

ryantm commented Mar 8, 2018

@GrahamcOfBorg eval

@matthewbauer matthewbauer merged commit 200e016 into NixOS:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mogorman @ryantm @GrahamcOfBorg @matthewbauer