Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapidjson: fix build error with gcc7 #36512

Merged
merged 1 commit into from Mar 8, 2018
Merged

rapidjson: fix build error with gcc7 #36512

merged 1 commit into from Mar 8, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Mar 8, 2018 •
edited

Motivation for this change

didn't build with gcc7.

cc ZHF #36453 - please backport to 18.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 8, 2018

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2018

@GrahamcOfBorg build rapidjson

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘rapidjson-1.1.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/libraries/rapidjson/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

-- Installing: /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0/share/doc/RapidJSON/examples/capitalize/capitalize.cpp
-- Installing: /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0/lib/cmake/RapidJSON/RapidJSONConfig.cmake
-- Installing: /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0/lib/cmake/RapidJSON/RapidJSONConfigVersion.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0/lib
patching script interpreter paths in /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0
checking for references to /build in /nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0...
/nix/store/7lzamjflhr89jfhdk46l6m1qp0401fdl-rapidjson-1.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

-- Installing: /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0/share/doc/RapidJSON/examples/serialize/serialize.cpp
-- Installing: /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0/lib/cmake/RapidJSON/RapidJSONConfig.cmake
-- Installing: /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0/lib/cmake/RapidJSON/RapidJSONConfigVersion.cmake
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0/lib 
patching script interpreter paths in /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0
checking for references to /tmp/nix-build-rapidjson-1.1.0.drv-0 in /nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0...
/nix/store/fvx97bhmpyccyi7nccfh8g4nmsh88x0f-rapidjson-1.1.0

@Mic92 Mic92 merged commit 1a7b549 into NixOS:master Mar 8, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2018

back-ported in 6d88a00

@xeji xeji deleted the rapidjson-gcc7 branch March 8, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @ryantm @Mic92 @GrahamcOfBorg