pythonPackages.pysdl2: init at 0.9.6 #36506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg eval |
|
Is anything wrong, preventing this from being merged? |
FRidh
requested changes
Mar 27, 2018
|
|
||
| buildPythonPackage rec { | ||
| pname = "PySDL2"; | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
The name attribute is added by buildPython* and should therefore be removed.
| # sandboxed. Disable for now. | ||
| doCheck = false; | ||
|
|
||
| src = fetchurl { |
| patches = [ ./PySDL2-dll.patch ]; | ||
| postPatch = '' | ||
| substituteInPlace sdl2/dll.py --replace \ | ||
| "DLL(\"SDL2\")" "DLL('${SDL2}/lib/libSDL2.so')" |
There was a problem hiding this comment.
stdenv.hostPlatform.extensions.sharedLibrary instead of .so.
|
Thanks for the review, should be fixed now. |
|
Any issues remaining? |
FRidh
reviewed
Mar 30, 2018
| }; | ||
|
|
||
| # deliberately not in propagated build inputs; the user can decide | ||
| # which library he/she wants to include. |
| ''; | ||
|
|
||
| meta = { | ||
| description = "PySDL2 is a wrapper around the SDL2 library and as such similar to the discontinued PySDL project. In contrast to PySDL, it has no licensing restrictions, nor does it rely on C code, but uses ctypes instead."; |
There was a problem hiding this comment.
The description should be fixed:
https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes
|
@GrahamcOfBorg build pythonPackages.pysdl2 python3Packages.pysdl2 |
|
Success on x86_64-linux (full log) Attempted: pythonPackages.pysdl2, python3Packages.pysdl2 Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pythonPackages.pysdl2, python3Packages.pysdl2 Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: pythonPackages.pysdl2, python3Packages.pysdl2 Partial log (click to expand)
|
|
Anything else? |
|
I've fixed the conflicts. Any chance of this being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
We have SDL2, but no Python support!
Things done
I commented out the whole
find_packagemagic that Python (and PySDL2) does and replaced it by the hard-coded library paths. I hope that's nixpkgs policy.build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)