Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nghttp2: 1.24.0 -> 1.31.0 #36462

Merged
merged 1 commit into from May 22, 2018
Merged

nghttp2: 1.24.0 -> 1.31.0 #36462

merged 1 commit into from May 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 7, 2018

Haven't updated this in a while..

cc #32040
(which is probably worth revisiting
and updating to include/replace this)

If that doesn't sound good,
at least we can update it (this PR).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Mar 11, 2018
Closed
@xeji
Copy link
Contributor

xeji commented May 5, 2018

@dtzWill since the other PR you mentioned seems stalled, let's go ahead with this, but let's bump to 1.31.1, there's a CVE fix: https://nghttp2.org/blog/2018/04/12/nghttp2-v1-31-1/

@lukateras
Copy link
Member

@GrahamcOfBorg build nghttp2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bg46nhiyij28rvwgw8s0riv499k366qk-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/bg46nhiyij28rvwgw8s0riv499k366qk-nghttp2-1.31.0-dev
checking for references to /build in /nix/store/bg46nhiyij28rvwgw8s0riv499k366qk-nghttp2-1.31.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/sdalj702a9sb7p1m7lqj0wngjpvjlgix-nghttp2-1.31.0-lib
shrinking /nix/store/sdalj702a9sb7p1m7lqj0wngjpvjlgix-nghttp2-1.31.0-lib/lib/libnghttp2.so.14.16.0
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sdalj702a9sb7p1m7lqj0wngjpvjlgix-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/sdalj702a9sb7p1m7lqj0wngjpvjlgix-nghttp2-1.31.0-lib
checking for references to /build in /nix/store/sdalj702a9sb7p1m7lqj0wngjpvjlgix-nghttp2-1.31.0-lib...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nghttp2

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/hzc67ycbhqs0c5hin2qkaafsl95f1wy7-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/hzc67ycbhqs0c5hin2qkaafsl95f1wy7-nghttp2-1.31.0-dev
checking for references to /build in /nix/store/hzc67ycbhqs0c5hin2qkaafsl95f1wy7-nghttp2-1.31.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/9m6vx19ymcyj1k37wn76k83mkim4afd8-nghttp2-1.31.0-lib
shrinking /nix/store/9m6vx19ymcyj1k37wn76k83mkim4afd8-nghttp2-1.31.0-lib/lib/libnghttp2.so.14.16.0
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9m6vx19ymcyj1k37wn76k83mkim4afd8-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/9m6vx19ymcyj1k37wn76k83mkim4afd8-nghttp2-1.31.0-lib
checking for references to /build in /nix/store/9m6vx19ymcyj1k37wn76k83mkim4afd8-nghttp2-1.31.0-lib...
/nix/store/ml5kai55q4i5jmd3p9cc321djdncfwsg-nghttp2-1.31.0-bin

@lukateras lukateras merged commit 2e7897a into NixOS:master May 22, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nghttp2

Partial log (click to expand)

patching script interpreter paths in /nix/store/rqljr0516dm7bwmkkgpsshpami50r2gz-nghttp2-1.31.0-bin
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/45lrwnhbqypbna9lg31q2fzmz3lw3bf8-nghttp2-1.31.0
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qylm6xdxy6pcl8wv7hrfd0ibs8lbclib-nghttp2-1.31.0-dev/lib
patching script interpreter paths in /nix/store/qylm6xdxy6pcl8wv7hrfd0ibs8lbclib-nghttp2-1.31.0-dev
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/r57gfqwrj1azn0mf6mjh4k7qz66g02x2-nghttp2-1.31.0-lib/lib
patching script interpreter paths in /nix/store/r57gfqwrj1azn0mf6mjh4k7qz66g02x2-nghttp2-1.31.0-lib
/nix/store/rqljr0516dm7bwmkkgpsshpami50r2gz-nghttp2-1.31.0-bin

@dtzWill dtzWill mentioned this pull request May 22, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @xeji @lukateras @GrahamcOfBorg