Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocean bouyancy not occuring in 1.3.1 RSS/ScaledRSS Textures/Kopernicus -5,-6 or -7 #277

Closed
Bornholio opened this issue Feb 27, 2018 · 19 comments

Comments

@Bornholio
Copy link

Bornholio commented Feb 27, 2018

[Current Answer is "Updated Earth.cfg in RSS" See https://github.com/KSP-RO/RealSolarSystem/pull/130]

Did not test with -4, previously -3 worked.

Other Mods involved, RO/RP0 (development) suite

Currently trying to isolate reason, but have seen a few others with similar issue and arrangement.

@Sigma88
Copy link
Contributor

Sigma88 commented Feb 27, 2018

could you check with these setups:

  • stock ksp + kopernicus
  • stock ksp + kopernicus + SD + rescale! (10x)
  • stock ksp + kopernicus + RSS

the first one to fail should give us an indication of what might be the issue

@Galileo88
Copy link

RSS doesn’t use SD or Rescale. My guess is something with RO/RP0 effecting the parts, causing them to “sink”

@Galileo88
Copy link

Not sure what he means by “ScaledRSS Textures” though...

@Bornholio
Copy link
Author

@Sigma88 Will do,
https://github.com/pap1723/ScaledRSS-Textures is needed for the newest master RSS

@Galileo88
Copy link

Gotcha, but you still probably don’t need to test with SD or Rescale

@Galileo88
Copy link

I would remove the RO/RP0 stuff and give it a try. I just ran RSS, without any other mods than what is required for RSS to work, and I didn’t have an issue.

@Bornholio
Copy link
Author

Test A
Test with: Kop-7, https://github.com/Kopernicus/Kopernicus/releases/tag/release-1.3.1-7
MM 3.0.4
MFI 1.2.4.0

Result: Ocean works fine

Test B
Kop-7, https://github.com/Kopernicus/Kopernicus/releases/tag/release-1.3.1-7
MM 3.0.4
MFI 1.2.4.0
RSS Master https://github.com/KSP-RO/RealSolarSystem
https://github.com/pap1723/ScaledRSS-Textures/releases 1.4(8k) textures

Result: Ocean doesn't appear, ASL indicator goes red and craft falls to ocean floor, blue color when camera is below surface otherwise no water appears. https://imgur.com/a/1ipXe

@Bornholio
Copy link
Author

@Galileo88
Copy link

Galileo88 commented Feb 27, 2018

ok so the issue lies with the dev version of RSS which as far as I know isn't being actively worked on at the moment and isn't known to work with the lastest kopernicus. I suggest you use Kopernicus 1.3.1-3 or earlier.

Edit: you beat me to it

for what its worth, there is no reason to update to the latest kopernicus, since the RSS dev version does not take advantage of any of the new changes anyway. So, really its pointless.

@Bornholio
Copy link
Author

Any thoughts on what we are doing wrong in it that changed from -3 to later? @NathanKell and @eggrobin 's updates tested out good earlier.

Linked issue KSP-RO/RealSolarSystem#127

@Galileo88
Copy link

I don't know what could be wrong. There have been a lot of changes after 1.3.1-3. It could be a number of things. I can take a look at the cfgs when I get some time

@Sigma88
Copy link
Contributor

Sigma88 commented Feb 27, 2018

My suggestion would be to remove all rss configs except for those needed for the earth and go from there

@PhineasFreak
Copy link

PhineasFreak commented Mar 1, 2018

What i noticed: using KittopiaTech, i checked the value of radius under the KerbinOcean (PQS) entry. For some reason it is set as 600000 m, the radius of Kerbin. Manually setting this to be 6371000 m allows the ocean to reappear and behave as expected.

Edit: so, this is just a scaling issue (ocean hidden below the body surface).

Sorry, something went wrong.

@Bornholio
Copy link
Author

Bornholio commented Mar 3, 2018

Good find. Is it ignoring the value in RSS then?
https://github.com/KSP-RO/RealSolarSystem/blob/master/GameData/RealSolarSystem/RSSKopernicus/Earth/Earth.cfg

displayName = Earth
isHomeWorld = true
radius = 6371000

Sorry, something went wrong.

@PhineasFreak
Copy link

PhineasFreak commented Mar 3, 2018

No, all bodies are loaded correctly, including their radii parameters. It looks more like if Kopernicus is ignoring the body radius value for the Ocean PQS and, instead, reusing the default (Kerbin) one.

Also, the above do not seem to apply to Titan: while the ocean is physically there upon landing (splash FX, physics, floating on the surface) it is invisible. No matter what the radius is, it will always be invisible.

Sorry, something went wrong.

@Bornholio
Copy link
Author

@PhineasFreak What patch do you need to set this manually?

@PhineasFreak
Copy link

None, i just played with the values that Kittopia exposes. I am not even sure if the ocean radius is exposed as a config parameter (it shouldn't - everything should be handled internally).

@PhineasFreak
Copy link

So, fortunately i was wrong. RSS just needed the missing Ocean{} nodes and now everything works perfectly!

@Sigma88
Copy link
Contributor

Sigma88 commented Mar 23, 2018

glad you found a solution!

@Sigma88 Sigma88 closed this as completed Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants