Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support country flag emojis #2212

Closed
jostyee opened this issue Mar 1, 2018 · 3 comments
Closed

Support country flag emojis #2212

jostyee opened this issue Mar 1, 2018 · 3 comments

Comments

@jostyee
Copy link

jostyee commented Mar 1, 2018

When submitting a feature or enhancement request:

  1. Explain briefly what the enhancement is and why you think it would be useful.

  2. Provide any other necessary or useful information regarding your issue, such as (code) examples or related links.

When submitting a bug report, please follow the following template:


Summary

Right now ST3 doesn't show country flag emojis correctly.

As https://emojipedia.org/flags/ describes, country flags are combined by two-letter country codes, which ST doesn't recognize

Expected behavior

For example, US country code should be showed as 🇺🇸

Actual behavior

Currently it's 🇺 🇸 in the editor.

Steps to reproduce

  1. First step
  2. Second step
  3. Third step

Environment

  • Operating system and version:
    • Mac OS 10.13
  • Sublime Text:
    • Build 3 build 3157
    • 64 bit
@wbond
Copy link
Member

wbond commented Mar 1, 2018

This is related to glyph caching and combining characters. You'll notice the flag in the tab title of a new file with 🇺🇸 in it. It boils down to how character and runs of characters are converted into glyphs, etc.

@jostyee
Copy link
Author

jostyee commented Mar 2, 2018

Thanks for explaining, so will you consider implementing it in future?

@wbond wbond added this to the Build 3158 milestone Mar 23, 2018
@wbond
Copy link
Member

wbond commented Mar 29, 2018

This was fixed in build 3158

@wbond wbond closed this as completed Mar 29, 2018
@wbond wbond added the R: fixed label Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants