-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jruby-1_7] Two failing tests in test/test_command_line_switches.rb #1849
Comments
Hey @ratnikov, this issue bisects to the introduction of LibrarySearcher in 613673a. Here's some extra information in case it helps: This is the command generated by this test for 1.9 (1.8 is similar):
Without 613673a (for instance, I checked out 1.7.13), this generates a number of warnings (about it not being 1.8), a couple of exceptions (side note: not sure if it's significant, but the 1.8 case does not have these exceptions), and some reasonable output. With 613673a, this outputs many, many errors and hangs the test for some reason that isn't jumping out at me.... Hopefully that's enough to help you zero straight in on the issue... let me know if there's more I can do to help. |
Oops. @ratnikov: I typoed your username in my comment. Fixed now, but I'm mentioning you again to make sure you're notified. |
Fun! Thanks for tracking this, will look at it. |
The -d flag is what causes it, by forcing to print all the class loading exceptions. The reason for class loading exceptions is because it attempts to find a 'Service' for a library probably for .rb suffixed, and not just 'extension' suffixes. |
More specifically, I guess prior to LibrarySearcher the process for loading via 'load' is slightly different than require and the exception was triggered only then. Now that they're uniform, we attempt to load XXXService even requires, causing much more ClassNotFoundExceptions and logging in debug mode. |
I guess there are a couple of options here:
@enebo Any input? :) |
Why does it hang? |
since 1.7.x has EOLed .. let's call this one a day, shall we 🍂 |
These hang:
test_dash_little_v_version_verbose_T_taint_d_debug_K_kcode_r_require_b_benchmarks_a_splitsinput_I_loadpath_C_cwd_F_delimeter_J_javaprop_18
test_dash_little_v_version_verbose_T_taint_d_debug_K_kcode_r_require_b_benchmarks_a_splitsinput_I_loadpath_C_cwd_F_delimeter_J_javaprop_19
I have no idea why, yet. Help wanted.
The text was updated successfully, but these errors were encountered: