PICARD-1204: Read and dump values to QSettings only when necessary #854
+32
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sambhav
changed the title
sambhav
force-pushed
the
picard_1204
branch
3 times, most recently
from
7da4fdc to
20fdc07
Compare
Reading and dumping too often from QSettings causes picard to lock up. This makes sure we only read on start and dump on change.
zas
requested changes
Mar 1, 2018
picard/config.py
Outdated
| self.load_keys() | ||
|
|
||
| def __qt_keys(self): | ||
| return filter(lambda key: key.startswith('%s/' % self.__name), |
There was a problem hiding this comment.
You may want to cache '%s/' % self.__name:
def __qt_keys(self):
prefix = '%s/' % self.__name
def prefixed(key):
return key.startswith(prefix)
return filter(prefixed, self.__qt_config.allKeys())
picard/tagger.py
Outdated
| @@ -230,7 +231,6 @@ def __init__(self, picard_args, unparsed_args, localedir, autoupdate): | |||
| self.unclustered_files = UnclusteredFiles() | |||
| self.nats = None | |||
| self.window = MainWindow() | |||
| self.exit_cleanup = [] | |||
There was a problem hiding this comment.
This change isn't needed anymore.
sambhav
force-pushed
the
picard_1204
branch
2 times, most recently
from
bdd62e8 to
ca9eaad
Compare
zas
requested changes
Mar 1, 2018
picard/config.py
Outdated
| self.load_keys() | ||
|
|
||
| def __qt_keys(self): | ||
| prefix = '%s/' % self.__name |
There was a problem hiding this comment.
Instead of using % format, since key building here are very simple, using concatenation will waste less cpu cycles.
Since config options can be read in loops, optimization makes sense, and doesn't cost much in readibility.
prefix = '%s/' % self.__name
key = "%s/%s" % (self.__name, name)vs
prefix = self.__name + '/'
key = self.__name + '/' + namefrom timeit import timeit
runs = 10000000
def print_results(time, start_string):
print('%s\nTotal: %.4f\nAvg: %.4fns\n' % (start_string, time,
(time/runs)*1000000000))
t1 = timeit('"%s/%s" % (a, b)',
setup='a="xxx"; b="yyy"',
number=runs)
t2 = timeit("a + '/' + b",
setup='a="xxx"; b="yyy"',
number=runs)
t3 = timeit('a + "/" + b',
setup='a="xxx"; b="yyy"',
number=runs)
t4 = timeit('"{}/{}".format(a, b)',
setup='a="xxx"; b="yyy"',
number=runs)
print_results(t1, '% replacement')
print_results(t2, 'concatenation single quotes')
print_results(t3, 'concatenation double quotes')
print_results(t4, '.format method')% replacement
Total: 3.1121
Avg: 311.2064ns
concatenation single quotes
Total: 1.6318
Avg: 163.1769ns
concatenation double quotes
Total: 1.7592
Avg: 175.9204ns
.format method
Total: 4.3462
Avg: 434.6209ns
sambhav
commented
Mar 1, 2018
|
|
||
| def raw_value(self, key): | ||
| def raw_value(self, name): |
There was a problem hiding this comment.
Did this so that there is a consistency between name and key
zas
approved these changes
Mar 1, 2018
|
|
||
| def raw_value(self, key): | ||
| def raw_value(self, name): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading and dumping too often from QSettings causes picard to lock up.
This makes sure we only read on start and dump on change.
Summary
Problem
Solution
Action