Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp_ethereum: mark as broken #36156

Closed
wants to merge 1 commit into from
Closed

cpp_ethereum: mark as broken #36156

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Mar 1, 2018 •
edited

Looks like it incompatible with current ethereum.

cc @artuuge

hydra build: https://hydra.nixos.org/build/70333858

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /var/lib/gc-of-borg/nix-test-rs-24/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-24/pkgs/applications/misc/cpp-ethereum/default.nix:78 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/rbvermaa-spot/pkgs/applications/misc/cpp-ethereum/default.nix:78 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/cpp-ethereum/default.nix:78 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member Author

Mic92 commented Mar 1, 2018

Is our ethereum too new? @gumb0
https://hydra.nixos.org/build/70333858

@gumb0
Copy link

gumb0 commented Mar 1, 2018

Is the question about the build failure of cpp-ethereum? If yes, where's the log or build error?

@Mic92
Copy link
Member Author

Mic92 commented Mar 1, 2018 •
edited

@gumb0 yes that was about cpp-ethereum, here is the build log: https://hydra.nixos.org/build/70333858/nixlog/1
I personally don't use it, but I noticed it no longer builds, when I was reviewing an upgrade of https://github.com/catchorg/Catch2 Also cpp-ethereum did not build before.

@gumb0 gumb0 mentioned this pull request Mar 1, 2018
Closed
@gumb0
Copy link

gumb0 commented Mar 1, 2018

Thank you for the report, we should fix this.

@Mic92
Copy link
Member Author

Mic92 commented Mar 1, 2018 •
edited

@gumb0 makes sense, we upgraded to gcc7 because of Spectre. We could also opt out cpp-ethereum if it needs more time for that.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/applications/misc/cpp-ethereum/default.nix:81 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/cpp-ethereum/default.nix:81 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /var/lib/gc-of-borg/nix-test-rs-17/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-17/pkgs/applications/misc/cpp-ethereum/default.nix:81 is marked as broken, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

      ^
/tmp/nix-build-cpp-ethereum-1.3.0.drv-0/source/libethash/internal.c:477:2: note: here
  case ETHASH_IO_MEMO_MISMATCH:
  ^~~~
cc1: all warnings being treated as errors
make[2]: *** [libethash/CMakeFiles/ethash.dir/build.make:87: libethash/CMakeFiles/ethash.dir/internal.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:306: libethash/CMakeFiles/ethash.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
builder for ‘/nix/store/g3hpn366117sb1rhdzzpi1v8s0s227bs-cpp-ethereum-1.3.0.drv’ failed with exit code 2
error: build of ‘/nix/store/g3hpn366117sb1rhdzzpi1v8s0s227bs-cpp-ethereum-1.3.0.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

../libcpuid/.libs/libcpuid.so: undefined reference to `exec_cpuid'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:388: cpuid_tool] Error 1
make[2]: Leaving directory '/build/source/cpuid_tool'
make[1]: *** [Makefile:459: all-recursive] Error 1
make[1]: Leaving directory '/build/source'
make: *** [Makefile:368: all] Error 2
builder for '/nix/store/00bk0b6iw7alcffgncnj3lxrqh7k72hm-libcpuid-0.4.0.drv' failed with exit code 2
cannot build derivation '/nix/store/v3czdjg1krdhm8mighx5zpmll8x2fd7q-cpp-ethereum-1.3.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/v3czdjg1krdhm8mighx5zpmll8x2fd7q-cpp-ethereum-1.3.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘cpp-ethereum-1.3.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/misc/cpp-ethereum/default.nix:81 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Aug 28, 2018

cpp_ethereum was marked broken in ccbefc6 (April 10), and the gcc6 downgrade didn't work. Should we close this as obsolete?

@Mic92 Mic92 closed this Aug 28, 2018
@Mic92 Mic92 deleted the cpp_ethereum branch August 28, 2018 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @GrahamcOfBorg @gumb0 @xeji