Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotify: 1.0.70.399.g5ffabd56-26 -> 1.0.69.336.g7edcc575-39 #36161

Merged
merged 1 commit into from Mar 3, 2018
Merged

spotify: 1.0.70.399.g5ffabd56-26 -> 1.0.69.336.g7edcc575-39 #36161

merged 1 commit into from Mar 3, 2018

Conversation

rvolosatovs
Copy link
Member

@rvolosatovs rvolosatovs commented Mar 1, 2018 •
edited

Motivation for this change

Upstream update. Current version results in 404.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Mar 1, 2018

Please use the stable version from (https://repository-origin.spotify.com/dists/stable/non-free/binary-amd64/Packages) 1.0.69

@rvolosatovs
Copy link
Member Author

I would also vote for using stable, but #34746 clearly goes against this?

@globin
Copy link
Member

globin commented Mar 1, 2018

That shouldn't have been merged, please switch to stable :)

This was referenced Mar 1, 2018
Closed
Closed
Closed
@retrry
Copy link
Contributor

retrry commented Mar 2, 2018 •
edited

@globin wouldn't it be easier to just revert #34746?

@sternenseemann sternenseemann mentioned this pull request Mar 2, 2018
Merged
8 tasks
@rvolosatovs rvolosatovs changed the title spotify: 1.0.70.399.g5ffabd56-26 -> 1.0.72.117.g6bd7cc73-35 spotify: 1.0.70.399.g5ffabd56-26 -> 1.0.69.336.g7edcc575-39 Mar 2, 2018
@rvolosatovs
Copy link
Member Author

@globin I updated this PR, please take a look

@Mic92 Mic92 merged commit b98e160 into NixOS:master Mar 3, 2018
@Ma27 Ma27 mentioned this pull request Mar 9, 2018
Merged
8 tasks
@rvolosatovs rvolosatovs deleted the update/spotify branch April 16, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rvolosatovs @globin @retrry @Mic92 @GrahamcOfBorg