-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert entity sidebars to React #623
Conversation
6707f72
to
6ff94de
Compare
No longer WIP. All of the |
4312420
to
df0d553
Compare
b039127
to
8fdd172
Compare
42122fd
to
40cf464
Compare
a9e35f9
to
09d4abd
Compare
09d4abd
to
81fed68
Compare
dcaf284
to
7c29fa7
Compare
This also now converts the collection, edit, and cdstub sidebars, which were the only ones left. |
This can't be imported at the top-level on the server, since jquery-ui needs a window to exist.
7c29fa7
to
27d4c8d
Compare
27d4c8d
to
d2c111d
Compare
$c->json has allow_blessed and convert_blessed enabled, so we can now serialize entities that contain blessed objects like cover art.
The basic idea was that CDStubTOC modeled cdtoc_raw, and CDStub modeled release_raw. But there's no clear reason why these are separate models, since the tables have a 1:1 mapping (I'm not actually sure why they're separate tables). You can't submit a CD stub without a disc ID. So these models only serve to make the code confusing as to when you should expect which entity. For example, the CDStub entity class previously had discid and track_count properties as shortcuts for the indexed search, which didn't construct a full CDStubTOC in `schema_fixup`. These shortcuts made it unclear when, for example, $cdstubtoc->discid was defined as opposed to $cdstubtoc->cdstub->discid, or if $cdstubtoc->cdstub could always be expected to be loaded.
The component uses different (and probably harder to translate) strings than the expiration_time TT macro, and wraps the result in bracketed, which the macro didn't do. This commit also renames the component to ExpirationTime to match the TT macro, which makes more sense.
This encompasses the edit page sidebar.
d2c111d
to
12368de
Compare
For hydrated components that take an entity prop, we were serializing the entire entity (potentially including a giant list of relationships, mediums, etc.) even though we only needed a few bits of data from it (such as the entity type and gid).
12368de
to
5b27ba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks terably good to me!
No description provided.