Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hash#last_key and Hash#last_value #5760

Merged
merged 1 commit into from Apr 7, 2018
Merged

Add Hash#last_key and Hash#last_value #5760

merged 1 commit into from Apr 7, 2018

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Mar 1, 2018

Cloned from Hash#first_key and Hash#first_value.
Enumerable#last isn't done yet.

@j8r j8r mentioned this pull request Mar 20, 2018
Closed
@j8r
Copy link
Contributor Author

j8r commented Apr 6, 2018

Somebody to review?

jhass
jhass approved these changes Apr 7, 2018
View reviewed changes
Copy link
Member

@jhass jhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feels weird to me have order dependent stuff on hash, but as long as we have first we should have last

@RX14 RX14 added this to the Next milestone Apr 7, 2018
@RX14 RX14 merged commit 3138b52 into crystal-lang:master Apr 7, 2018
@j8r j8r deleted the last_key_value_hash branch April 14, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j8r @jhass @RX14