Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop forcing hmatrix-gsl to use gsl 1.16 and use gsl 2.4 instead #36157

Merged
merged 2 commits into from Mar 1, 2018
Merged

Stop forcing hmatrix-gsl to use gsl 1.16 and use gsl 2.4 instead #36157

merged 2 commits into from Mar 1, 2018

Conversation

idontgetoutmuch
Copy link
Contributor

Motivation for this change

gsl 1.6 is very old and is no longer required to build hmatrix-gsl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peti
Copy link
Member

peti commented Mar 1, 2018

@GrahamcOfBorg build haskellPackages.hmatrix-gsl

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1/lib
patching script interpreter paths in /nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1
/nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHShmatrix-gsl-0.18.0.1-HKJMyTMffjr1vvXD2DdboT-ghc8.2.2.dylib: fixing dylib
/nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHShmatrix-gsl-0.18.0.1-HKJMyTMffjr1vvXD2DdboT-ghc8.2.2.dylib: fixing dylib
/nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHShmatrix-gsl-0.18.0.1-HKJMyTMffjr1vvXD2DdboT-ghc8.2.2.dylib: fixing dylib
/nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHShmatrix-gsl-0.18.0.1-HKJMyTMffjr1vvXD2DdboT-ghc8.2.2.dylib: fixing dylib
/nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1/lib/ghc-8.2.2/x86_64-osx-ghc-8.2.2/libHShmatrix-gsl-0.18.0.1-HKJMyTMffjr1vvXD2DdboT-ghc8.2.2.dylib: fixing dylib
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/kk09j3k6hny2397irpjfiplgds1wyfq9-hmatrix-gsl-0.18.0.1-doc
/nix/store/3ribfxvwykrcvxnylx207i5rk67mx37q-hmatrix-gsl-0.18.0.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/w28kpm461bd5qpqpcvqj11zc24zblavv-hmatrix-gsl-0.18.0.1/lib/ghc-8.2.2/x86_64-linux-ghc-8.2.2/libHShmatrix-gsl-0.18.0.1-HKJMyTMffjr1vvXD2DdboT-ghc8.2.2.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w28kpm461bd5qpqpcvqj11zc24zblavv-hmatrix-gsl-0.18.0.1/lib 
patching script interpreter paths in /nix/store/w28kpm461bd5qpqpcvqj11zc24zblavv-hmatrix-gsl-0.18.0.1
checking for references to /tmp/nix-build-hmatrix-gsl-0.18.0.1.drv-0 in /nix/store/w28kpm461bd5qpqpcvqj11zc24zblavv-hmatrix-gsl-0.18.0.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/k5rlkmvx30hy0frsrxfg7j849va1h38i-hmatrix-gsl-0.18.0.1-doc
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/k5rlkmvx30hy0frsrxfg7j849va1h38i-hmatrix-gsl-0.18.0.1-doc
checking for references to /tmp/nix-build-hmatrix-gsl-0.18.0.1.drv-0 in /nix/store/k5rlkmvx30hy0frsrxfg7j849va1h38i-hmatrix-gsl-0.18.0.1-doc...
/nix/store/w28kpm461bd5qpqpcvqj11zc24zblavv-hmatrix-gsl-0.18.0.1

@peti peti merged commit 56f1785 into NixOS:master Mar 1, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/m1anc5hbgxqd0ddxhwn6h5ghqab4vj0d-random-1.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ssbc552vyrdl50lnzq3m1p4axf5zrywc-semigroups-0.18.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/0hrxgk8d57wqqvw7kw9vkhph5rkmrrzk-storable-complex-0.2.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/d6wg1f4hfs9cgy83b5hb8lld10hmldwm-tf-random-0.5.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/1pzmicbw94jpdmrwh29d9h1abj5lqzpa-vector-0.12.0.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/b3fpk14rgm4kv9n74ki1si5mgx6rwrwl-QuickCheck-2.10.1.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/0a34zhq3rdy2m0b7qwacip6vvzqq227a-split-0.2.3.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/fn85iz3c331mwsqjrfy6hf449gqdshcf-hmatrix-0.18.2.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/x4glixfvra6yd8z38327wqmgin9npghz-hmatrix-gsl-0.18.0.1.drv': 6 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/x4glixfvra6yd8z38327wqmgin9npghz-hmatrix-gsl-0.18.0.1.drv' failed

@idontgetoutmuch
Copy link
Contributor Author

Am I supposed to do something?

@peti
Copy link
Member

peti commented Mar 6, 2018

About the aarch64-linux failure? No, I don't think it's necessary to worry about that at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@idontgetoutmuch @peti @GrahamcOfBorg