Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybase 1.0.44 #36154

Merged
merged 3 commits into from Mar 4, 2018
Merged

Keybase 1.0.44 #36154

merged 3 commits into from Mar 4, 2018

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Mar 1, 2018

Motivation for this change

Minor version bumps for keybase packages. Note: updating these packages together prevents runtime errors that can be caused by version mismatches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Mar 2, 2018

@GrahamcOfBorg build keybase kbfs keybase-gui

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44/share/go/src/github.com/keybase/client/packaging/github/kbfs.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44/share/go/src/github.com/keybase/client/packaging/github/keybase.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44/share/go/src/github.com/keybase/client/packaging/check_status_and_pull.sh: interpreter directive changed from " /usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44/share/go/src/github.com/keybase/client/packaging/ios/build_and_publish.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44/share/go/src/github.com/keybase/client/packaging/slack/send.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
/nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44/share/go/src/github.com/keybase/client/packaging/brew/brew.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-keybase-1.0.44.drv-0 in /nix/store/53yk0v9y9gfgci5kifzirhbwzldwfb2b-keybase-1.0.44...
/nix/store/slr907q9vd6lanr6p8n0lycg77d8vvc3-keybase-1.0.44-bin
/nix/store/6khspp38lmrrvlxpyr176kbid480bzds-kbfs-1.0.44-bin
/nix/store/n2lv5qhq17i6rwdj70bqvc4d5njl8hsm-keybase-gui-1.0.44-20180223200436.9a9ccec79

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/gpy3r9ss5ngfkib8ylx7jzgahq7m0x5b-patch-shebangs.sh: line 22: warning: command substitution: ignored null byte in input
/nix/store/plgpvm50ywv1d4v40gvfyhcw408gd70j-keybase-1.0.44/share/go/src/github.com/keybase/client/shared/jenkins_test.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/plgpvm50ywv1d4v40gvfyhcw408gd70j-keybase-1.0.44/share/go/src/github.com/keybase/client/shared/react-native/uploadApp.sh: interpreter directive changed from "/bin/bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/plgpvm50ywv1d4v40gvfyhcw408gd70j-keybase-1.0.44/share/go/src/github.com/keybase/client/shared/react-native/android/gradlew: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
/nix/store/plgpvm50ywv1d4v40gvfyhcw408gd70j-keybase-1.0.44/share/go/src/github.com/keybase/client/shared/react-native/gobuild.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/plgpvm50ywv1d4v40gvfyhcw408gd70j-keybase-1.0.44...
/nix/store/cq6qyzci88lmihc95sj90jmh8x6vdaf1-keybase-1.0.44-bin
/nix/store/szln4hnx3wi72kcfpl1gvy75padz8v5i-kbfs-1.0.44-bin
/nix/store/csa7aq4pc2k6mylljwjl20x2qvxipmdc-keybase-gui-1.0.44-20180223200436.9a9ccec79

@joachifm joachifm merged commit 9b732aa into NixOS:master Mar 4, 2018
@jonafato jonafato deleted the keybase-1.0.44 branch March 4, 2018 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @nlewo @GrahamcOfBorg @joachifm