Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partio: 1.1.0 -> 2018-03-01 #36158

Merged
merged 1 commit into from Mar 3, 2018
Merged

partio: 1.1.0 -> 2018-03-01 #36158

merged 1 commit into from Mar 3, 2018

Conversation

guibou
Copy link
Contributor

@guibou guibou commented Mar 1, 2018

  • The version 1.1.0 is 6 years old and was not compiling anymore with GCC 7.0
  • Fixed buildInputs / nativeBuildInputs
Motivation for this change

Partio was not building anymore since recent GCC 7.0 changes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [X ] NixOS
    • macOS
    • [X ] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested with our proprietary tool, it build / link / works.

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

@GrahamcOfBorg build partio

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Call Stack (most recent call first):
  /nix/store/f8fpahh907cfi7jzdk7hmwg0mvd1bpaq-cmake-3.10.2/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
  /nix/store/f8fpahh907cfi7jzdk7hmwg0mvd1bpaq-cmake-3.10.2/share/cmake-3.10/Modules/FindGLUT.cmake:116 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:84 (find_package)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-partio-2018-03-01.drv-0/source/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/f4pgi4n5hd2sjpr59jklx3mg1jkzbx7p-partio-2018-03-01.drv' failed with exit code 1
error: build of '/nix/store/f4pgi4n5hd2sjpr59jklx3mg1jkzbx7p-partio-2018-03-01.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/rsbnm32qmb78zaf6zaay8wp45xyrwwfa-partio-2018-03-01/bin 
patching script interpreter paths in /nix/store/rsbnm32qmb78zaf6zaay8wp45xyrwwfa-partio-2018-03-01
checking for references to /tmp/nix-build-partio-2018-03-01.drv-0 in /nix/store/rsbnm32qmb78zaf6zaay8wp45xyrwwfa-partio-2018-03-01...
shrinking RPATHs of ELF executables and libraries in /nix/store/49ys6a1ra31h99rgppg6wv08v1bq915x-partio-2018-03-01-lib
shrinking /nix/store/49ys6a1ra31h99rgppg6wv08v1bq915x-partio-2018-03-01-lib/lib/libpartio.so
shrinking /nix/store/49ys6a1ra31h99rgppg6wv08v1bq915x-partio-2018-03-01-lib/lib/python2.7/site-packages/_partio.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/49ys6a1ra31h99rgppg6wv08v1bq915x-partio-2018-03-01-lib/lib 
patching script interpreter paths in /nix/store/49ys6a1ra31h99rgppg6wv08v1bq915x-partio-2018-03-01-lib
checking for references to /tmp/nix-build-partio-2018-03-01.drv-0 in /nix/store/49ys6a1ra31h99rgppg6wv08v1bq915x-partio-2018-03-01-lib...

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

By looking at the dependencies, we should probably also disable macOS here.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

patching script interpreter paths in /nix/store/zkrcqibks48y1r6zh5jm9fcnd9915b8n-partio-2018-03-01
checking for references to /build in /nix/store/zkrcqibks48y1r6zh5jm9fcnd9915b8n-partio-2018-03-01...
shrinking RPATHs of ELF executables and libraries in /nix/store/gfjrh49mr3nc60z5nvfq71q84r5sfrbi-partio-2018-03-01-lib
shrinking /nix/store/gfjrh49mr3nc60z5nvfq71q84r5sfrbi-partio-2018-03-01-lib/lib/python2.7/site-packages/_partio.so
shrinking /nix/store/gfjrh49mr3nc60z5nvfq71q84r5sfrbi-partio-2018-03-01-lib/lib/libpartio.so
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/gfjrh49mr3nc60z5nvfq71q84r5sfrbi-partio-2018-03-01-lib/lib
patching script interpreter paths in /nix/store/gfjrh49mr3nc60z5nvfq71q84r5sfrbi-partio-2018-03-01-lib
checking for references to /build in /nix/store/gfjrh49mr3nc60z5nvfq71q84r5sfrbi-partio-2018-03-01-lib...
/nix/store/s237f06hszjw8rp4rsh702fvxn2xv1kh-partio-2018-03-01-dev

@guibou
Copy link
Contributor Author

guibou commented Mar 2, 2018

@Mic92 I'm not used to the platforms field. Should I just set it to platforms.linux or this is too restrictive?

@Mic92
Copy link
Member

Mic92 commented Mar 2, 2018

@guibou yes.

@guibou
partio: 1.1.0 -> 2018-03-01
4f031c0 
- The version 1.1.0 is 6 years old and was not compiling anymore with GCC 7.0
- Fixed buildInputs / nativeBuildInputs
- Set platform to linux, it does not work on OSX
@guibou
Copy link
Contributor Author

guibou commented Mar 3, 2018

@Mic92: done

@Mic92 Mic92 merged commit ce82ae1 into NixOS:master Mar 3, 2018
@Mic92
Copy link
Member

Mic92 commented Mar 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guibou @Mic92 @GrahamcOfBorg