move texstudio from qt4 to qt5 #34794

ajs124 · 2018-02-10T00:53:57Z

Motivation for this change

The move from qt4 to qt5 is motivated by #32883, because poppler_qt4 is deprecated.

Texstudio is one of the 4 remaining packages using poppler_qt4, but it also supports qt5.
I also tried upgrading texmaker to version 5.0.2 and fix the same issue for it, but could not get it to compile.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

andir · 2018-02-10T01:00:13Z

@GrahamcOfBorg build texstudio

GrahamcOfBorg · 2018-02-10T01:00:54Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘texstudio-2.12.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/editors/texstudio/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-10T01:00:59Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: tabdialog.ui: command not found
/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: arraydialog.ui: command not found
/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: letterdialog.ui: command not found
make: *** [Makefile:2528: .ui/ui_letterdialog.h] Error 127
make: *** [Makefile:2522: .ui/ui_arraydialog.h] Error 127
make: *** [Makefile:2525: .ui/ui_tabdialog.h] Error 127
/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: quickdocumentdialog.ui: command not found
make: *** [Makefile:2531: .ui/ui_quickdocumentdialog.h] Error 127
builder for '/nix/store/6slmgjqczg5bym7vn4zndmsgxfxpjw0r-texstudio-2.12.6.drv' failed with exit code 2
error: build of '/nix/store/6slmgjqczg5bym7vn4zndmsgxfxpjw0r-texstudio-2.12.6.drv' failed

Mic92 · 2018-02-10T01:10:27Z

@andir there seems something seriously broken with qmake.

GrahamcOfBorg · 2018-02-10T01:12:19Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6
shrinking /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6/bin/texstudio
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6/bin 
patching script interpreter paths in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6
checking for references to /tmp/nix-build-texstudio-2.12.6.drv-0 in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6

andir · 2018-02-10T19:20:26Z

@GrahamcOfBorg build texstudio

GrahamcOfBorg · 2018-02-10T19:20:43Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘texstudio-2.12.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/editors/texstudio/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-10T19:21:13Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

tabbingdialog.ui -o .ui/ui_tabbingdialog.h
/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: filechooser.ui: command not found
make: *** [Makefile:2513: .ui/ui_filechooser.h] Error 127
make: *** Waiting for unfinished jobs....
/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: insertgraphics.ui: command not found
make: *** [Makefile:2516: .ui/ui_insertgraphics.h] Error 127
/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/bash: tabbingdialog.ui: command not found
make: *** [Makefile:2519: .ui/ui_tabbingdialog.h] Error 127
builder for '/nix/store/6slmgjqczg5bym7vn4zndmsgxfxpjw0r-texstudio-2.12.6.drv' failed with exit code 2
error: build of '/nix/store/6slmgjqczg5bym7vn4zndmsgxfxpjw0r-texstudio-2.12.6.drv' failed

GrahamcOfBorg · 2018-02-10T19:22:55Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6
shrinking /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6/bin/texstudio
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6/bin
patching script interpreter paths in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6
checking for references to /build in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6

andir · 2018-02-10T19:55:13Z

@GrahamcOfBorg build texstudio

GrahamcOfBorg · 2018-02-10T19:55:30Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘texstudio-2.12.6’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/editors/texstudio/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-10T20:05:13Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

                                ^~~~~~
bookmarks.cpp: In member function 'void Bookmarks::updateLineWithBookmark(int)':
bookmarks.cpp:162:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(!dlh)
     ^~
bookmarks.cpp:164:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
  QList<QListWidgetItem *> lst = bookmarksWidget->findItems(text, Qt::MatchStartsWith);
  ^~~~~
builder for '/nix/store/6slmgjqczg5bym7vn4zndmsgxfxpjw0r-texstudio-2.12.6.drv' failed with exit code 2
error: build of '/nix/store/6slmgjqczg5bym7vn4zndmsgxfxpjw0r-texstudio-2.12.6.drv' failed

GrahamcOfBorg · 2018-02-10T20:09:59Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6
shrinking /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6/bin/texstudio
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6/bin 
patching script interpreter paths in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6
checking for references to /tmp/nix-build-texstudio-2.12.6.drv-0 in /nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/15jm8p17wcjhwhcjw6ma8b68fhks1nl3-texstudio-2.12.6

andir · 2018-02-10T23:42:54Z

@ajs124 Can you please have a look at the aarch64 output and see if you can find a solution? If not please change the supported platforms to just "x86_64-linux".

ajs124 · 2018-02-12T14:59:25Z

I tried to disable that warning, but I kind of doubt that did anything, because qmake is being qmake. So if it doesn't compile, I'll set supported platforms to "x86_64-linux" and remove the NIX_COMPILE_CFLAGS thing again.

andir · 2018-02-12T21:14:20Z

@GrahamcOfBorg build texstudio

GrahamcOfBorg · 2018-02-12T21:14:44Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘texstudio-2.12.6’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/editors/texstudio/default.nix:21 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-12T21:23:12Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  memcpy(&STACK_FROM_UCONTEXT(context), &this->stack, sizeof(char*));
          ^~~~~~~~~~~~~~~~~~~
make: *** [Makefile:5048: .obj/debughelper.o] Error 1
make: *** Waiting for unfinished jobs....
latexstructure.cpp: In member function 'void StructureEntry::debugPrint(const char*) const':
latexstructure.cpp:90:2: warning: nonnull argument 'this' compared to NULL [-Wnonnull-compare]
  if (!this) return;
  ^~
builder for '/nix/store/3lpk8l5mzndx93835s3ackcvsqpp04sf-texstudio-2.12.6.drv' failed with exit code 2
error: build of '/nix/store/3lpk8l5mzndx93835s3ackcvsqpp04sf-texstudio-2.12.6.drv' failed

GrahamcOfBorg · 2018-02-12T22:16:49Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/w1lcfyrb616hblprgklkplgp8vm4g99w-texstudio-2.12.6
shrinking /nix/store/w1lcfyrb616hblprgklkplgp8vm4g99w-texstudio-2.12.6/bin/texstudio
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/w1lcfyrb616hblprgklkplgp8vm4g99w-texstudio-2.12.6/bin 
patching script interpreter paths in /nix/store/w1lcfyrb616hblprgklkplgp8vm4g99w-texstudio-2.12.6
checking for references to /tmp/nix-build-texstudio-2.12.6.drv-0 in /nix/store/w1lcfyrb616hblprgklkplgp8vm4g99w-texstudio-2.12.6...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/w1lcfyrb616hblprgklkplgp8vm4g99w-texstudio-2.12.6

ajs124 · 2018-02-12T23:41:45Z

Ok, I can also disable that warning, but I'm not sure why it occurs and if it's safe to disable. How would you prefer this to be handled?

andir · 2018-02-13T12:05:41Z

It is not the warning that made the build fail. There are more compile time issues: https://logs.nix.ci/?key=nixos/nixpkgs.34794&attempt_id=6e5953b7-b303-4b14-8a10-0428fa8ccd49

Can you restrict this to x86_64-linux unless you want to investigate further? :-)

@GrahamcOfBorg eval

ajs124 · 2018-02-13T15:39:06Z

Ok, I restricted it to x86_64-linux. Thanks for your help on this.

GrahamcOfBorg added 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Feb 10, 2018

ajs124 force-pushed the update/texmaker_and_studio branch from 8cd769d to 5d7400a Compare February 12, 2018 14:57

texstudio: move from qt4 to qt5

0ee6040

ajs124 force-pushed the update/texmaker_and_studio branch from 5d7400a to 0ee6040 Compare February 13, 2018 15:34

GrahamcOfBorg added the 8.has: clean-up label Feb 13, 2018

andir merged commit 358b821 into NixOS:master Feb 13, 2018

ajs124 deleted the update/texmaker_and_studio branch July 31, 2018 11:17

Janik-Haag added the 12. first-time contribution label Jun 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move texstudio from qt4 to qt5 #34794

move texstudio from qt4 to qt5 #34794

ajs124 commented Feb 10, 2018

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

Mic92 commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

andir commented Feb 10, 2018

ajs124 commented Feb 12, 2018

andir commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

ajs124 commented Feb 12, 2018

andir commented Feb 13, 2018

ajs124 commented Feb 13, 2018

move texstudio from qt4 to qt5 #34794

move texstudio from qt4 to qt5 #34794

Conversation

ajs124 commented Feb 10, 2018

Motivation for this change

Things done

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

Mic92 commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

andir commented Feb 10, 2018

ajs124 commented Feb 12, 2018

andir commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

GrahamcOfBorg commented Feb 12, 2018

ajs124 commented Feb 12, 2018

andir commented Feb 13, 2018

ajs124 commented Feb 13, 2018