trivial: fetchurl more securely #34793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. |
|
I hate to assault you at random places, but can you please also merge
- #34778 (trivial)
- #33898 (discussed before, all issues fixed)
- #29440 (the not-cherry-picked patches are mostly trivial, I run on top of this for months)
- #27688 (its awesome, I have patches that depend on this and run on top if it for months)
|
|
I don't feel comfortable merging the last one, but I sent mail to the mailing list about it. Thanks for the pings, glad to get these merged :) |
|
I don't feel comfortable merging the last one, but I sent mail to the mailing list about it. Thanks for the pings, glad to get these merged :)
Fair enough. Huge thanks!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Obvious.
Things done