Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure.ac: check if lzma has MT support, fix deb build/etc. #1857

Merged
merged 3 commits into from Feb 19, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 10, 2018

Check is simple but seems to do the job on debian at least,
more complicated checks that include linking may be required
but it seems best to keep this simple for now.

@shlevy
Copy link
Member

shlevy commented Feb 10, 2018

Should this error out if the user requests parallel decompression but it's not available? Probably not, but want to raise the question...

@copumpkin
Copy link
Member

Maybe issue a warning in that case, since we're now making an effort to be friendly when people ask for nonsense, rather than just silently ignoring them

@dtzWill
Copy link
Member Author

dtzWill commented Feb 11, 2018

Okay, now emits warnings. Was a bit clumsy and redundant, so refactored a bit to try to improve things...

Not sure I love what I ended up with, but can't spend more on this right now;
included commit that just adds warnings, maybe grab that if preferred.

Also warns when requesting parallel compression with a method other than "xz".

@edolstra
Copy link
Member

Ping @AmineChikhaoui

@edolstra edolstra merged commit 7fe5910 into NixOS:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants