Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infamousPlugins: 0.2.03 -> 0.2.04 #34813

Merged
merged 1 commit into from Feb 10, 2018
Merged

infamousPlugins: 0.2.03 -> 0.2.04 #34813

merged 1 commit into from Feb 10, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 10, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 5c0e310 into NixOS:master Feb 10, 2018
@magnetophon
Copy link
Member Author

Hi @Mic92 You're on a roll again, thanks!

Would you mind taking a look at #33561 as well?
Thanks!

@magnetophon magnetophon deleted the infamousPlugins branch February 10, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @Mic92