New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos: labels part 2 #34795
Merged
Merged
nixos: labels part 2 #34795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reintroduces a better version of what 2a05368 removed.
oxij
force-pushed
the
os/nixosLabel-pt2
branch
from
February 18, 2018 12:57
681fe40
to
c6d8a58
Compare
@GrahamcOfBorg test installer |
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
@GrahamcOfBorg test installer.simple |
1 similar comment
@GrahamcOfBorg test installer.simple |
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
This pull request breaks nixops: NixOS/nixops#871 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Continuation of #10996 on steroids and some OCD-related changes.
Now you can do, e.g.
and it will influence the label. This is useful for farming clusters of computers with different configurations as
for a in <machine-list>; do echo -n "$a "; ssh $a -- "basename $(readlink -f /run/current-system) | cut -d- -f2-"; done
then can show everything you want to know.681fe402c0b6570d6ae767853bd56e195b1f49c9 introduces what 2a05368 removed because that feature is useful no matter how much of 47950b5 and 0b9d9ed you add.
Things done