Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple users with hashedPassword is broken in mosquitto #34804

Closed
wants to merge 1 commit into from
Closed

Multiple users with hashedPassword is broken in mosquitto #34804

wants to merge 1 commit into from

Conversation

noqqe
Copy link
Contributor

@noqqe noqqe commented Feb 10, 2018

See #34753 for reference.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

You'll probably want to target release-17.09 instead.

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

sorry, my bad. this was a typo from my side.

Mic92 pushed a commit that referenced this pull request Feb 10, 2018
@noqqe @Mic92
Multiple users with hashedPassword is broken in mosquitto
b1cbce8 
If you have more than 1 User with hasedPassword Option set it generates

```
rm -f /var/lib/mosquitto/passwd
touch /var/lib/mosquitto/passwd
echo 'user1:$6$xxx' > /var/lib/mosquitto/passwd
echo 'user2:$6$xxx' > /var/lib/mosquitto/passwd
```

Which ends up in only having 1 user.

fixes #34804

(cherry picked from commit 7e76b12)
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

I back ported it now myself to the correct branch.

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

Thanks!

@Mic92 Mic92 closed this Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noqqe @dotlambda @Mic92