Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

looking-glass-client: restrict to x86_64-linux #34782

Merged
merged 1 commit into from Feb 10, 2018
Merged

looking-glass-client: restrict to x86_64-linux #34782

merged 1 commit into from Feb 10, 2018

Conversation

kliu128
Copy link

@kliu128 kliu128 commented Feb 9, 2018 •
edited

Motivation for this change

The AArch64 build fails after trying to pull in tmmintrin.h:

../common/memcpySSE.h:24:23: fatal error: tmmintrin.h: No such file or directory
 #include <tmmintrin.h>
                       ^
compilation terminated.
make: *** [Makefile:29: .build/renderers/opengl.o] Error 1

Which are SSSE3 intrinsics unsupported on ARM. This package also likely would not be useful on ARM, as it requires KVM and a compatible KVM guest running the frame relay (usually Windows).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

looking-glass-client: restrict to x86_64-linux
a5524e4 
The AArch64 build fails after trying to pull in tmmintrin.h:

```
../common/memcpySSE.h:24:23: fatal error: tmmintrin.h: No such file or directory
 #include <tmmintrin.h>
                       ^
compilation terminated.
make: *** [Makefile:29: .build/renderers/opengl.o] Error 1
```

Which are SSSE3 intrinsics unsupported on ARM. This package also likely would
not be useful on ARM, as it requires KVM and a compatible KVM guest running
the frame relay (usually Windows).
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

@GrahamcOfBorg build looking-glass-client

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘looking-glass-client-a10’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/applications/virtualization/looking-glass-client/default.nix:34 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 17384  100 17384    0     0  42400      0 --:--:-- --:--:-- --:--:-- 42400

fetching path ‘/nix/store/ssym48iwd7a3a0gdvwzy9lyrz3clgf0q-looking-glass-client-a10’...

*** Downloading ‘https://cache.nixos.org/nar/01kq905jprvnq0bg5lfbca8v9mfh4qr6k9p0pbbl9nds86glkxkj.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/ssym48iwd7a3a0gdvwzy9lyrz3clgf0q-looking-glass-client-a10’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 71 22508   71 16076    0     0  58458      0 --:--:-- --:--:-- --:--:-- 58246
100 22508  100 22508    0     0  81550      0 --:--:-- --:--:-- --:--:-- 81256

/nix/store/ssym48iwd7a3a0gdvwzy9lyrz3clgf0q-looking-glass-client-a10

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘looking-glass-client-a10’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/applications/virtualization/looking-glass-client/default.nix:34 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92 Mic92 merged commit 053453c into NixOS:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kliu128 @Mic92 @GrahamcOfBorg