Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: housekeeping #34807

Merged
merged 5 commits into from Feb 10, 2018
Merged

python: housekeeping #34807

merged 5 commits into from Feb 10, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

/cc chardet maintainer @domenkozar

@FRidh FRidh merged commit 2b16b1a into NixOS:staging Feb 10, 2018
@dotlambda dotlambda deleted the python branch February 10, 2018 10:56
@dotlambda
Copy link
Member Author

I tried installing aiohttp on an ARMv7 machine (Banana Pi) and was shocked to see that it needs to build gfortran first (build is still running after 24h). I think this is because

aiohttp -> ... -> multidict -> cython -> numpy (nativeBuildInputs) -> gfortran

This change seems to have removed the dependency on gfortran 🎉 (because multidict doesn't depend on cython anymore)
However, nix why-depends didn't show a dependency on gfortran on my x86_64 machine (I can't run it on ARMv7 since I'd need to complete the build of aiohttp first). Two questions:

  1. Does nix why-depends also consider checkInputs and nativeBuildInputs?
  2. Is there a way to run it without building first?

@FRidh
Copy link
Member

FRidh commented Feb 10, 2018

nix why-depends considers store paths. For build dependencies you need to use the .drv files as produced by nix-instantiate, however, that does not yet seem to be supported.

The old-fashioned way:

nix-store -qR $(nix-instantiate -A python3.pkgs.aiohttp) | grep fortran

@dotlambda
Copy link
Member Author

Thanks a lot! Not quite as nice as why-depends as there is no graph but it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @FRidh