Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: remove dependencies which should be loaded via autoExtraComponents #34810

Merged
merged 1 commit into from Feb 10, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change

I especially want to get rid of mutagen in order to avoid the dependency on libvorbis.

Regarding the recorder component: It is depended upon by the history component. But in parse-requirements.py, there is currently no way to detect such dependencies. I will have to come up with a better way to generate component-packages.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member Author

/cc @FRidh

@FRidh FRidh merged commit 9f24e68 into NixOS:master Feb 10, 2018
@dotlambda dotlambda deleted the home-assistant branch February 10, 2018 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants