boot.kernel.features: add nixos option for setting kernel features #34791

bendlas · 2018-02-09T22:41:14Z

Motivation for this change

The motivation is submitted in the form of additional commits on this PR:

provide options for installing systemtap and criu; both profit from / require custom kernel config
optionally enabling CONFIG_DEBUG_INFO, for use with systemtap
optionally enabling CONFIG_CHECKPOINT_RESTORE, which is required by criu

Review requested

Is it done the right way?
What about the section re-enabling flags, that, for some reason, got disabled by CONFIG_EXPERT (EXPERT is needed for CHECKPOINT_RESTORE) d86f252#diff-ad3f665c58e343da48fc9981dde5afaeR690

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

GrahamcOfBorg · 2018-02-09T23:12:02Z

Success on aarch64-linux (full log)

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/lxvqgcmllzd2if24js1nyd43r3msczlr-linux-4.9.80

GrahamcOfBorg · 2018-02-09T23:54:48Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

  CC [M]  drivers/pci/hotplug/shpchp_hpc.o
  LD [M]  drivers/pci/hotplug/shpchp.o
  CC [M]  drivers/pci/hotplug/acpiphp_ibm.o
  CC      drivers/pci/pcie/aspm.o
  CC      drivers/pci/pcie/portdrv_core.o
  CC      drivers/pci/pcie/portdrv_pci.o
  CC      drivers/pci/pcie/portdrv_bus.o
  CC      drivers/pci/pcie/portdrv_acpi.o
building of ‘/nix/store/70w8ifg3wvndk7c47c4gnrkb6vghj8hf-linux-4.9.80.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/70w8ifg3wvndk7c47c4gnrkb6vghj8hf-linux-4.9.80.drv’ failed

andir · 2018-02-10T00:43:09Z

nixos/modules/system/boot/kernel.nix

+      default = {};
+      example = literalExample "{ debug = true; }";
+      description = ''
+        This option allows to enable or certain kernel features.


seems like there is an disable missing in the description

andir · 2018-02-10T00:46:45Z

I like the idea of exposing kernel features like that. We could eventually also use that for things like the spectre and meltdown mitigations. I know that @fpletz was thinking about such a way to configure this.
The general way to configure features looks fine to me.

I can not judge the configuration for CRIU or systemtap.

GrahamcOfBorg · 2018-02-10T01:01:28Z

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/lxvqgcmllzd2if24js1nyd43r3msczlr-linux-4.9.80

GrahamcOfBorg · 2018-02-10T01:25:32Z

Success on x86_64-linux (full log)

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/d962jhp5pqaywvcw9bmb5hgfs5sb96r5-linux-4.9.80

NeQuissimus · 2018-02-10T16:49:50Z

@GrahamcOfBorg test kernel-lts

NeQuissimus · 2018-02-10T16:49:54Z

@GrahamcOfBorg test kernel-latest

NeQuissimus · 2018-02-10T16:50:04Z

@GrahamcOfBorg test kernel-copperhead

GrahamcOfBorg · 2018-02-10T16:50:29Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

while evaluating the option `boot.kernelPackages':
while evaluating the attribute 'isDefined' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:344:5:
while evaluating 'filterOverrides' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:419:21, called from /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:328:18:
while evaluating 'concatMap' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/lists.nix:102:18, called from /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:425:8:
while evaluating 'concatMap' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/lists.nix:102:18, called from /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:323:17:
while evaluating anonymous function at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:323:28, called from undefined position:
while evaluating 'dischargeProperties' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:386:25, called from /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:324:62:
while evaluating the attribute 'value' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/modules.nix:216:48:
while evaluating the attribute 'config.kernelPackages' at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/nixos/tests/kernel-copperhead.nix:9:7:
attribute 'linuxPackages_hardened_copperhead' missing, at /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/nixos/tests/kernel-copperhead.nix:9:29

GrahamcOfBorg · 2018-02-10T16:50:31Z

Success on x86_64-linux (full log)

Partial log (click to expand)

machine# [    7.467137] dhcpcd[763]: eth0: IAID 00:12:34:56
machine# [    7.467784] dhcpcd[763]: eth0: adding address fe80::5054:ff:fe12:3456
machine# [    7.681703] input: ImExPS/2 Generic Explorer Mouse as /devices/platform/i8042/serio1/input/input4
machine: exit status 0
test script finished in 8.57s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/wc33p63rxdbgzffdbp0z4dps7wiy519l-vm-test-run-kernel-lts

GrahamcOfBorg · 2018-02-10T16:50:38Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

while evaluating the option `boot.kernelPackages':
while evaluating the attribute 'isDefined' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:344:5:
while evaluating 'filterOverrides' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:419:21, called from /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:328:18:
while evaluating 'concatMap' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/lists.nix:102:18, called from /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:425:8:
while evaluating 'concatMap' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/lists.nix:102:18, called from /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:323:17:
while evaluating anonymous function at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:323:28, called from undefined position:
while evaluating 'dischargeProperties' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:386:25, called from /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:324:62:
while evaluating the attribute 'value' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/lib/modules.nix:216:48:
while evaluating the attribute 'config.kernelPackages' at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/nixos/tests/kernel-copperhead.nix:9:7:
attribute 'linuxPackages_hardened_copperhead' missing, at /home/borg/borg-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/7c6f434c-buildbox/nixos/tests/kernel-copperhead.nix:9:29

GrahamcOfBorg · 2018-02-10T16:50:58Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation ‘/nix/store/yvyzrr7alliivyy1shvlb3a1p1l9h8y5-etc.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/lbggcwgm9wqyr9yzdkp4ylnsc8sm0h12-stage-1-init.sh.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/ihp2f95zwgshkz8f3jp32yqfljzgrbsk-initrd.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/sb2l8xsvfish2n7j8bhkw76l6gr0qbpi-nixos-system-machine-18.03.git.69f14c0.drv’: 5 dependencies couldn't be built
cannot build derivation ‘/nix/store/fd4k0rp27qchfn5v96xii159i6fgprsi-closure-info.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/shx2lrly2bjlyjpa8kr2hmqmlshbx4hw-run-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/lcnrdiqlzy1gc17qq32d1d6qwd7syvy3-nixos-vm.drv’: 2 dependencies couldn't be built
cannot build derivation ‘/nix/store/6d7ci4kr2mvb70x89mc8q5wv5ys8adbl-nixos-test-driver-kernel-latest.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/c89yxzn26df9c7mp7jj8y5hqhbzgym9m-vm-test-run-kernel-latest.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/c89yxzn26df9c7mp7jj8y5hqhbzgym9m-vm-test-run-kernel-latest.drv’ failed

GrahamcOfBorg · 2018-02-10T17:21:59Z

Success on aarch64-linux (full log)

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 14.27s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/pknym1flwk8qbyrf2ry5r29v7fg9zvnx-vm-test-run-kernel-lts

GrahamcOfBorg · 2018-02-10T17:23:49Z

Success on aarch64-linux (full log)

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 14.61s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/31wwxqiwbzq12jjq2dmp3ava1ak75k7v-vm-test-run-kernel-latest

bendlas

features should be introduced to the kernel via the existing override in kernelPackages

bendlas · 2018-02-14T01:08:52Z

nixos/modules/system/boot/kernel.nix

-  inherit (config.boot.kernelPackages) kernel;
+  kernel =  config.boot.kernelPackages.kernel.override {
+    inherit (config.boot.kernel) features;
+  };



this override doesn't work at all. besides, it's ugly.
it should be overridden in boot.kernelPackages, a few lines down.
I'm currently running a build for that.

bendlas · 2018-02-14T01:23:35Z

I redid the override, hopefully fixing it.
I also set the option to internal, because it's not clear to me how to properly document it.

GrahamcOfBorg · 2018-02-14T01:50:21Z

Success on aarch64-linux (full log)

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/zhmb4jv153l3glh1dxb8vvnhr96g2ycz-linux-4.9.81

GrahamcOfBorg · 2018-02-14T02:32:33Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/dm.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/hw.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/led.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/phy.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/rf.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.o
  CC [M]  drivers/net/wireless/realtek/rtlwifi/rtl8192cu/table.o
building of ‘/nix/store/ap7p0i32zmdirrxj68nwh3spbb31i9vk-linux-4.9.81.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/ap7p0i32zmdirrxj68nwh3spbb31i9vk-linux-4.9.81.drv’ failed

this allows setting the features attribute for pkgs/os-specific/linux/kernel/common-config.nix

also enables debug feature on kernel

This isn't useful as public API. It should be used by options to activate kernel features for use with specific programs.

GrahamcOfBorg · 2018-02-15T07:50:36Z

Success on aarch64-linux (full log)

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/zhmb4jv153l3glh1dxb8vvnhr96g2ycz-linux-4.9.81

GrahamcOfBorg · 2018-02-15T08:28:52Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

  CC [M]  drivers/net/wireless/marvell/mwifiex/11n.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/11ac.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/11n_aggr.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/11n_rxreorder.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/scan.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/join.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/sta_ioctl.o
  CC [M]  drivers/net/wireless/marvell/mwifiex/sta_cmd.o
building of ‘/nix/store/ap7p0i32zmdirrxj68nwh3spbb31i9vk-linux-4.9.81.drv’ timed out after 3600 seconds
error: build of ‘/nix/store/ap7p0i32zmdirrxj68nwh3spbb31i9vk-linux-4.9.81.drv’ failed

bendlas added 0.kind: enhancement 6.topic: nixos 6.topic: kernel 9.needs: changelog 8.has: module (new) 3 - Review labels Feb 9, 2018

bendlas requested review from NeQuissimus and vcunat February 9, 2018 22:41

GrahamcOfBorg added 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 501+ and removed 6.topic: kernel labels Feb 9, 2018

andir reviewed Feb 10, 2018

View reviewed changes

bendlas force-pushed the nixos-kernel-features branch from fabf7d4 to fe9b15b Compare February 10, 2018 00:53

NeQuissimus approved these changes Feb 10, 2018

View reviewed changes

bendlas force-pushed the nixos-kernel-features branch from fe9b15b to 92bb426 Compare February 14, 2018 01:20

bendlas commented Feb 14, 2018

View reviewed changes

bendlas removed the 9.needs: changelog label Feb 14, 2018

bendlas added 5 commits February 15, 2018 08:20

boot.kernel.features: add nixos option for setting kernel features

818b54b

this allows setting the features attribute for pkgs/os-specific/linux/kernel/common-config.nix

programs.criu: add nixos option for installing criu + kernel flags

2175442

linuxPackages.kernel: add feature.debug flag for enabling DEBUG_INFO

d7b078b

programs.systemtap: add nixos option for installing systemtap

c640934

also enables debug feature on kernel

nixos: make boot.kernel.features internal

c1e7903

This isn't useful as public API. It should be used by options to activate kernel features for use with specific programs.

bendlas force-pushed the nixos-kernel-features branch from 92bb426 to c1e7903 Compare February 15, 2018 07:20

bendlas merged commit 23b5421 into NixOS:master Feb 15, 2018

bendlas deleted the nixos-kernel-features branch October 22, 2023 02:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

boot.kernel.features: add nixos option for setting kernel features #34791

boot.kernel.features: add nixos option for setting kernel features #34791

bendlas commented Feb 9, 2018 •

edited

GrahamcOfBorg commented Feb 9, 2018

GrahamcOfBorg commented Feb 9, 2018

andir Feb 10, 2018

bendlas Feb 10, 2018

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

NeQuissimus commented Feb 10, 2018

NeQuissimus commented Feb 10, 2018

NeQuissimus commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

bendlas left a comment

bendlas Feb 14, 2018

bendlas commented Feb 14, 2018

GrahamcOfBorg commented Feb 14, 2018

GrahamcOfBorg commented Feb 14, 2018

GrahamcOfBorg commented Feb 15, 2018

GrahamcOfBorg commented Feb 15, 2018

boot.kernel.features: add nixos option for setting kernel features #34791

boot.kernel.features: add nixos option for setting kernel features #34791

Conversation

bendlas commented Feb 9, 2018 • edited

Motivation for this change

Review requested

Things done

GrahamcOfBorg commented Feb 9, 2018

GrahamcOfBorg commented Feb 9, 2018

andir Feb 10, 2018

Choose a reason for hiding this comment

bendlas Feb 10, 2018

Choose a reason for hiding this comment

andir commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

NeQuissimus commented Feb 10, 2018

NeQuissimus commented Feb 10, 2018

NeQuissimus commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

GrahamcOfBorg commented Feb 10, 2018

bendlas left a comment

Choose a reason for hiding this comment

bendlas Feb 14, 2018

Choose a reason for hiding this comment

bendlas commented Feb 14, 2018

GrahamcOfBorg commented Feb 14, 2018

GrahamcOfBorg commented Feb 14, 2018

GrahamcOfBorg commented Feb 15, 2018

GrahamcOfBorg commented Feb 15, 2018

bendlas commented Feb 9, 2018 •

edited