Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

racket-minimal: init at 6.12.0 (same as racket) #34801

Merged
merged 4 commits into from Feb 21, 2018

Conversation

clacke
Copy link
Contributor

@clacke clacke commented Feb 10, 2018

Racket without the bundled packages, such as Mr Racket.

The essential package racket-libs is included, as well as libraries
that live in collections. In particular, raco and the pkg library are
still bundled.

Motivation for this change

I am working on racket2nix, which will make racket-minimal much more useful. Also, I want to merge a change that makes racket compile on darwin, and currently only racket-minimal works and can verify that the compiled racket works, due to one package in the full racket having a test failure on darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [✓] macOS (with the darwin patch)
    • [✓] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [✓] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [✓] Tested execution of all binary files (usually in ./result/bin/)
  • [✓] Fits CONTRIBUTING.md.

Racket without the bundled packages, such as Mr Racket.

The essential package racket-libs is included, as well as libraries
that live in collections. In particular, raco and the pkg library are
still bundled.
@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

@GrahamcOfBorg build racket racket-minimal

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘racket-6.12’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/development/interpreters/racket/default.nix:77 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘racket-6.12’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/interpreters/racket/default.nix:77 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

@GrahamcOfBorg build racket-minimal

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘racket-minimal-6.12’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/interpreters/racket/default.nix:77 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘racket-minimal-6.12’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/interpreters/racket/default.nix:77 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/lib/racket/gracket
shrinking /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/lib/libracket3m-6.12.so
gzipping man pages under /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/lib  /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/bin
patching script interpreter paths in /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12
/nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12...
wrong ELF type
/nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

wrong ELF type
gzipping man pages under /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/share/man/
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/lib  /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/bin 
patching script interpreter paths in /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12
/nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-racket-minimal-6.12.drv-0 in /nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12...
wrong ELF type
/nix/store/l8mpp15xp5h6g3jsz1556hq4w6hq3cnc-racket-6.12
/nix/store/rm4jgl2jhdmv0b2jlr2jmziih8clximf-racket-minimal-6.12

@gebner
Copy link
Member

gebner commented Feb 10, 2018

such as Mr Racket

Do you mean DrRacket?

sha256 = "0c565jy2y3gjl5lncd5adjsrj8c24p4i062kphv26ni5q1nn5ip5";
};

description = "Racket without bundled packages, such as Mr Racket.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dr.Racket?

@Mic92
Copy link
Member

Mic92 commented Feb 13, 2018

racket-minimal should also override meta.platforms to include darwin. Otherwise it will be also marked as broken on hydra. It would be also interesting to see if aarch64 is supported for that build.

@clacke
Copy link
Contributor Author

clacke commented Feb 13, 2018

@Mic92 Thanks for pointing out the meta.platforms thing!

It doesn't build on Darwin yet. That's my next pull request. I'll modify meta.platforms then.

Move description and longDescription to meta -- they were accidentally
in the parent set.
@clacke
Copy link
Contributor Author

clacke commented Feb 16, 2018

@GrahamcOfBorg build racket-minimal

@clacke
Copy link
Contributor Author

clacke commented Feb 16, 2018

Ah. Makes sense that I can't request that.

@joachifm joachifm assigned vrthra and unassigned vrthra Feb 17, 2018
@joachifm joachifm requested a review from vrthra February 17, 2018 09:09
@clacke
Copy link
Contributor Author

clacke commented Feb 19, 2018

Could someone with access ask @GrahamcOfBorg to build racket-minimal. Or should I bother to figure out how to cross-compile it and run it in emulation?

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

@GrahamcOfBorg build racket-minimal

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘racket-minimal-6.12’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/interpreters/racket/minimal.nix:12 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12/lib/racket/mzdyn3m.o
wrong ELF type
gzipping man pages under /nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12/share/man/
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12/lib  /nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12/bin 
patching script interpreter paths in /nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12
/nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fcxliihmhm2ak9z4890gk0qw63zsbrcx-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-racket-minimal-6.12.drv-0 in /nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12...
wrong ELF type
/nix/store/5cqcggd4937jg5qmvbhb4dw6vwa06m1y-racket-minimal-6.12

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12/lib/racket/starter
shrinking /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12/bin/.racket-wrapped
gzipping man pages under /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12/share/man/
strip is /nix/store/skd6ix5ipkyhxzq7naylj4digawakl4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12/lib  /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12/bin
patching script interpreter paths in /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12
/nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12/bin/.raco-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/shjmvsnwrlg7rd8m0kzgpygqq4if312z-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12...
wrong ELF type
/nix/store/ckll6pqnnn1r6kasbsdwcaxbx5hmvvs5-racket-minimal-6.12

@Mic92 Mic92 merged commit 3f90db6 into NixOS:master Feb 21, 2018
@clacke clacke deleted the racket-minimal branch February 21, 2018 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants