Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linphone: 3.10.2 -> 3.12.0 #34800

Merged
merged 8 commits into from Feb 12, 2018
Merged

linphone: 3.10.2 -> 3.12.0 #34800

merged 8 commits into from Feb 12, 2018

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Feb 10, 2018 •
edited

Motivation for this change

#34669 broke the linphone build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @ryantm @peti

@adisbladis adisbladis mentioned this pull request Feb 10, 2018
Merged
1 task
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

error: while evaluating the attribute 'nativeBuildInputs' of the derivation 'belle-sip-1.6.3' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute 'buildInputs' of the derivation 'openjdk-8u172b02' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:148:11:
while evaluating the attribute 'buildCommand' of the derivation 'openjdk-bootstrap' at /var/lib/gc-of-borg/nix-test-rs-2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-2/pkgs/stdenv/generic/make-derivation.nix:148:11:
No bootstrap for system

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘bctoolbox-0.6.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/libraries/bctoolbox/default.nix:16 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin/.lpc2xml_test-wrapped
shrinking /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin/.notify-wrapped
shrinking /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin/.realtimetext_receiver-wrapped
shrinking /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin/.realtimetext_sender-wrapped
shrinking /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin/.registration-wrapped
shrinking /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin/.xml2lpc_test-wrapped
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/lib  /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0/bin
patching script interpreter paths in /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0
checking for references to /build in /nix/store/mv9hzr4qwpk4y1p1dcaq3jbypnhgs60v-linphone-3.12.0...

@ryantm
Copy link
Member

ryantm commented Feb 10, 2018

Cool, I was working on this tonight too and you beat me to it. I don't think ortp is a dependency of linphone anymore. This builds for me on NixOS.

@ryantm
Copy link
Member

ryantm commented Feb 10, 2018

Yes, it builds for me without ortp as a dependency.

@adisbladis
Copy link
Member Author

adisbladis commented Feb 10, 2018 •
edited

@ryantm ortp might be an optional dependency. The linphone-daemon binary links against libortp.
https://gist.github.com/adisbladis/930eaa14d5d3ca58c1ecf4b3ec856230

@adisbladis adisbladis merged commit 81a6e50 into NixOS:master Feb 12, 2018
@MarcFontaine
Copy link
Contributor

Do you know what has happened to the the actual linphone executable.
(i.e. the main linphone GUI-application)
It is available in /nix/store/7hcx9ilqpdz25sa4r4lhdwwf9lyys7qf-linphone-3.10.2/bin
but gone in linphone-3.12.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adisbladis @GrahamcOfBorg @ryantm @MarcFontaine @fpletz