Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bottled/Mineral/Purfied Water shops #37

Closed
govvin opened this issue Feb 5, 2018 · 4 comments
Closed

Update Bottled/Mineral/Purfied Water shops #37

govvin opened this issue Feb 5, 2018 · 4 comments
Assignees
@govvin
Labels
kula-laba-kusot-banlaw

Comments

@govvin
Copy link
Member

govvin commented Feb 5, 2018 •
edited

Most of these Bottled/Mineral/Purified Water shops may be currently tagged incorrectly as :

  • amenity=drinking_water
  • amenity=water_point
  • shop=beverages
  • shop=purified_water
  • shop=water_refilling

These objects will be retrieved via Overpass Turbo, and reviewed individually, and replaced with shop=water, as appropriate.

The appropriate entry in the local convention page has been updated.
@govvin govvin self-assigned this Feb 5, 2018
@seav
Copy link
Member

seav commented Feb 5, 2018

I have no objection to this proposal. 👍

@govvin
Copy link
Member Author

govvin commented Feb 10, 2018 •
edited

Fixed! See changeset:

Objects which don't have information (e.g. from their name) that didn't identify them as such a shop were left as-is.

Other objects retrieved from this query we're re-tagged as appropriate, based on available information. The more common ones were:

  • man_made=water_tap
  • man_made=water_well
  • natural=spring
  • emergency=fire_hydrant
  • office=company
  • government=public_utility

You may reuse this Overpass Turbo query, as part of future maintenance tasks for PH data.

@govvin govvin closed this as completed Feb 10, 2018
@schadow1
Copy link

schadow1 commented Feb 10, 2018 via email

@govvin
Copy link
Member Author

govvin commented Feb 10, 2018 •
edited

Filled a ticket in carto, so this could considered for default rendering on the map.
gravitystorm/openstreetmap-carto#3060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@govvin govvin

Labels
kula-laba-kusot-banlaw
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seav @govvin @schadow1