Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/rspamd: Preserve runtime directory when using socket activation #35690

Merged
merged 1 commit into from Sep 27, 2018

Conversation

griff
Copy link
Contributor

@griff griff commented Feb 27, 2018

Motivation for this change

When I added support for socket activation to rspamd module in #34562 I missed that systemd deletes the RuntimeDirectory when the service is stopped. Since the default worker socket is in that directory it means that if the service is stopped the socket is deleted which means the socket unit needs to be restarted for the socket to be recreated.

Setting the RuntimeDirectoryPreserve option stops systemd from deleting the runtime directory so this change does that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 27, 2018

also backported: 0f4e117

@griff griff deleted the rspamd-socketruntime branch November 5, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants