Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Port PW to python 3 #111

Closed
wants to merge 1 commit into from
Closed

Conversation

samj1912
Copy link
Collaborator

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PW-XXX

Solution

Action

@samj1912 samj1912 changed the title Port PW to python 3 [WIP] Port PW to python 3 Feb 26, 2018
@vishichoudhary
Copy link

@samj1912 in run.py instead of
#!/usr/bin/env python2
there shouldn't be #!/usr/bin/env python3?

@samj1912
Copy link
Collaborator Author

samj1912 commented Feb 26, 2018

@vishichoudhary yup, I haven't really converted everything, just made it functional and made the non-plugin tests pass. Readme and script shebangs are left along with a couple nits here and there as evident in the diff.

@samj1912 samj1912 force-pushed the py3port branch 4 times, most recently from f9fbc07 to 8c5b58d Compare February 26, 2018 19:23
@zas
Copy link
Collaborator

zas commented Mar 12, 2018

@sambhav : status ?

@samj1912
Copy link
Collaborator Author

I am pondering how to handle building 1.0 plugins correctly. I was thinking of reading a truncated version of the file and then parsing it with AST. Another possibility is to use python2 for 1.0 compilation.

@samj1912
Copy link
Collaborator Author

Closing this for now. @vishichoudhary feel free to take it up if you are interested.

@samj1912 samj1912 closed this Apr 12, 2018
@vishichoudhary
Copy link

Merely a half-day work, You can do it better than me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants