Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipxe: fix ISO build, update the package #35685

Merged
merged 2 commits into from Apr 23, 2018
Merged

ipxe: fix ISO build, update the package #35685

merged 2 commits into from Apr 23, 2018

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented Feb 26, 2018 •
edited

Motivation for this change

Without the build change, it doesn't seem to properly generate ISOs with embedded scripts.
The package update is because we might as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@edef1c
ipxe: fix ISO build
4d7bea7 
Without this change, it doesn't seem to properly generate ISOs with
embedded scripts.
@edef1c edef1c changed the title ipxe: fix ISO build ipxe: fix ISO build, upgrade the package Feb 27, 2018
@edef1c edef1c changed the title ipxe: fix ISO build, upgrade the package ipxe: fix ISO build, update the package Feb 27, 2018
@matthewbauer matthewbauer merged commit 1439d0b into NixOS:master Apr 23, 2018
@edef1c edef1c deleted the ipxe-iso branch April 24, 2018 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edef1c @matthewbauer @GrahamcOfBorg