Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strace: fix source tarball #35686

Merged
merged 1 commit into from Feb 27, 2018
Merged

strace: fix source tarball #35686

merged 1 commit into from Feb 27, 2018

Conversation

lheckemann
Copy link
Member

Motivation for this change

The previous version was not the actual release, and was not supposed to
be published at all. This one is the signed release. Additionally,
upstream plans no more releases on sourceforge so the URL has been
changed to refer to strace.io instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

@GrahamcOfBorg build strace

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘strace-4.21’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/misc/strace/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21
shrinking /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin/strace
gzipping man pages under /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin 
patching script interpreter paths in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21
/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/s029gmjpgvm776wfb56naqny9qja9339-perl-5.24.3/bin/perl"
checking for references to /tmp/nix-build-strace-4.21.drv-0 in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21...
/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21

@dtzWill
Copy link
Member

dtzWill commented Feb 26, 2018

Looks like it needs depsBuildBuild = [ buildPackages.stdenv.cc ]; to fix on cross (and add buildPackages as argument at top).

Otherwise it complains about not being able to find a native C compiler.

@vcunat
Copy link
Member

vcunat commented Feb 26, 2018

I suppose we should update the homepage, too.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21

@dtzWill
Copy link
Member

dtzWill commented Feb 26, 2018

Oh, it needed that already, I thought I'd fixed this already--I must've but hasn't made it upstream yet O:).
Nevermind.

Thanks for chasing this down!

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘strace-4.21’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/tools/misc/strace/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21
shrinking /nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21/bin/strace
gzipping man pages under /nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21/bin
patching script interpreter paths in /nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21
/nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/lnws52qanbi5vz8qg24v4ym57nznfndg-bash-4.4-p12/bin/sh"
/nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/g1naqig0jxakwmf8688d95xfm8xch4dm-perl-5.24.3/bin/perl"
checking for references to /build in /nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21...
/nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21

@vcunat
Copy link
Member

vcunat commented Feb 26, 2018

Also /cc maintainers: @jgeerds, @globin.

@lheckemann
strace: fix source tarball
a886584 
The previous version was not the actual release, and was not supposed to
be published at all. This one is the signed release. Additionally,
upstream plans no more releases on sourceforge so the URL has been
changed to refer to strace.io instead.
@lheckemann
Copy link
Member Author

Fixed homepage, thanks @vcunat

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

/nix/store/dp68xhpqzkrk1r8lnl148q969la9dzvc-strace-4.21

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘strace-4.21’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/development/tools/misc/strace/default.nix:20 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21
shrinking /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin/strace
gzipping man pages under /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin 
patching script interpreter paths in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21
/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin/strace-log-merge: interpreter directive changed from "/bin/sh" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/sh"
/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21/bin/strace-graph: interpreter directive changed from "/usr/bin/perl" to "/nix/store/s029gmjpgvm776wfb56naqny9qja9339-perl-5.24.3/bin/perl"
checking for references to /tmp/nix-build-strace-4.21.drv-0 in /nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21...
/nix/store/bww28i3z5w3n0swxk7k88jdxwwypdsnh-strace-4.21

@vcunat vcunat merged commit a886584 into NixOS:master Feb 27, 2018
vcunat added a commit that referenced this pull request Feb 27, 2018
@vcunat
Merge #35686: strace: fix source tarball
c5be8a4
@lheckemann lheckemann deleted the strace-source-fix branch February 27, 2018 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lheckemann @Mic92 @GrahamcOfBorg @dtzWill @vcunat