Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mp3blaster: Build with support for ogg vorbis #35683

Merged
merged 1 commit into from Feb 27, 2018
Merged

mp3blaster: Build with support for ogg vorbis #35683

merged 1 commit into from Feb 27, 2018

Conversation

calvertvl
Copy link
Contributor

Motivation for this change

This package usually supports OGG but was built with only support for MP3 and WAV.

Adding libvorbis means that mp3blaster can now play OGG files.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Feb 26, 2018 via email •
edited

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6/bin/splay
shrinking /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6/bin/nmixer
shrinking /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6/bin/mp3blaster
shrinking /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6/bin/mp3tag
gzipping man pages under /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6/share/man/
strip is /nix/store/97ahf6sg6mwnl98bksrjvbp4zb4yq44n-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6/bin 
patching script interpreter paths in /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6
checking for references to /tmp/nix-build-mp3blaster-3.2.6.drv-0 in /nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6...
/nix/store/bndf753lsknykhfqmpv0178sk1v3lmkw-mp3blaster-3.2.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6/bin/splay
shrinking /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6/bin/mp3tag
shrinking /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6/bin/mp3blaster
shrinking /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6/bin/nmixer
gzipping man pages under /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6/share/man/
strip is /nix/store/ggjc1mfsicyq31xlg5d51hl9lc21wxnv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6/bin
patching script interpreter paths in /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6
checking for references to /build in /nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6...
/nix/store/wky8yv55hbg7n5rwn78jdjc2862yk57l-mp3blaster-3.2.6

@nlewo nlewo merged commit ec3547e into NixOS:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calvertvl @nlewo @GrahamcOfBorg