Fixing a race with timed suspension #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
reviewed
Feb 7, 2018
| @@ -300,7 +300,8 @@ namespace hpx { namespace threads { namespace detail | |||
| thread_init_data data( | |||
| util::bind(&wake_timer_thread, | |||
There was a problem hiding this comment.
Using bind_front would remove the need for the placeholder here.
When doing a timed suspension on a thread, there were several race conditions between setting the different participating thread states, which should now be fixed. The problem was observable with the wait_for_1751 regression test.
sithhell
force-pushed
the
fix_timed_suspension
branch
from
3f00c42
to
7ee57c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a timed suspension on a thread, there were several race conditions
between setting the different participating thread states, which should now be
fixed. The problem was observable with the wait_for_1751 regression test.