Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.1.14 -> 7.2.2 #34705

Merged
merged 1 commit into from Feb 13, 2018
Merged

php: 7.1.14 -> 7.2.2 #34705

merged 1 commit into from Feb 13, 2018

Conversation

etu
Copy link
Contributor

@etu etu commented Feb 7, 2018 •
edited by andir

Motivation for this change

PHP 7.2 has now gotten two patch releases which is usually good enough for sensible people to actually start using it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Feb 7, 2018

@GrahamcOfBorg build php

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (16.29 MiB download, 81.31 MiB unpacked):
  /nix/store/xl9m6v8zlpj026hx64r3gkscyvqvz1wv-php-7.2.2
copying path '/nix/store/xl9m6v8zlpj026hx64r3gkscyvqvz1wv-php-7.2.2' from 'https://cache.nixos.org'...
/nix/store/xl9m6v8zlpj026hx64r3gkscyvqvz1wv-php-7.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

  /nix/store/4fc0811f5ljvjcrll63mphcsj5y95ban-php-7.2.2
fetching path ‘/nix/store/4fc0811f5ljvjcrll63mphcsj5y95ban-php-7.2.2’...
could not download ‘http://192.168.0.203:32062/4fc0811f5ljvjcrll63mphcsj5y95ban.narinfo’ (Curl error 7)

*** Downloading ‘http://cache.nixos.org/nar/1z2423bhnxrk70xs064c4jjbkkba1j0qizbdhjq84bjl8hc7wqps.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/4fc0811f5ljvjcrll63mphcsj5y95ban-php-7.2.2’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  2 18.4M    2  426k    0     0   426k      0  0:00:44 --:--:--  0:00:44  470k
 14 18.4M   14 2660k    0     0  2660k      0  0:00:07  0:00:01  0:00:06 1414k
 37 18.4M   37 7003k    0     0  3501k      0  0:00:05  0:00:02  0:00:03 2424k
 47 18.4M   47 9069k    0     0  3023k      0  0:00:06  0:00:03  0:00:03 2341k
 52 18.4M   52 9925k    0     0  2481k      0  0:00:07  0:00:04  0:00:03 2037k
 62 18.4M   62 11.4M    0     0  2344k      0  0:00:08  0:00:05  0:00:03 2274k
 77 18.4M   77 14.3M    0     0  2454k      0  0:00:07  0:00:06  0:00:01 2417k
100 18.4M  100 18.4M    0     0  2699k      0  0:00:07  0:00:07 --:--:-- 2392k

/nix/store/4fc0811f5ljvjcrll63mphcsj5y95ban-php-7.2.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

these paths will be fetched (13.17 MiB download, 61.91 MiB unpacked):
  /nix/store/gm5j55mgbn0nlf73a3lm678874g76422-php-7.2.2
copying path '/nix/store/gm5j55mgbn0nlf73a3lm678874g76422-php-7.2.2' from 'https://cache.nixos.org'...
/nix/store/gm5j55mgbn0nlf73a3lm678874g76422-php-7.2.2

@grahamc
Copy link
Member

grahamc commented Feb 7, 2018

@GrahamcOfBorg test wordpress

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

web: exit status 1
syncing
web: running command: sync
web: exit status 0
test script finished in 27.45s
cleaning up
killing web (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/64p8qlislc55jpp03pkb81k6kg7q2np6-vm-test-run-wordpress

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

web: exit status 1
syncing
web: running command: sync
web: exit status 0
test script finished in 173.50s
cleaning up
killing web (pid 596)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/tmp/nix-build-vm-test-run-wordpress.drv-0/vde1.ctl': Directory not empty
/nix/store/q6k3grb27yv01nrs2h6zmjyrq9fwk9vv-vm-test-run-wordpress

@andir
Copy link
Member

andir commented Feb 9, 2018

CC @globin @fpletz You both are suggested reviewer would be nice to if you could give us a short (N)ACK :-)

@etu
Copy link
Contributor Author

etu commented Feb 13, 2018

No opinions at all on this? @globin is maintainer for the php packages...

@fpletz fpletz merged commit 08d3754 into NixOS:master Feb 13, 2018
@fpletz
Copy link
Member

fpletz commented Feb 13, 2018

Thanks!

@etu etu deleted the php-upgrade branch February 13, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@etu @grahamc @GrahamcOfBorg @andir @fpletz